github-actions[bot] closed pull request #11348: Flink Support for
TIMESTAMP_NANOS
URL: https://github.com/apache/iceberg/pull/11348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
github-actions[bot] commented on PR #11348:
URL: https://github.com/apache/iceberg/pull/11348#issuecomment-2509489537
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If
github-actions[bot] commented on PR #11348:
URL: https://github.com/apache/iceberg/pull/11348#issuecomment-2495713885
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
pvary commented on code in PR #11348:
URL: https://github.com/apache/iceberg/pull/11348#discussion_r1814267518
##
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/data/FlinkParquetReaders.java:
##
@@ -411,6 +416,43 @@ public DecimalData read(DecimalData ignored) {
}
rodmeneses commented on code in PR #11348:
URL: https://github.com/apache/iceberg/pull/11348#discussion_r1813237820
##
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/TypeToFlinkType.java:
##
@@ -113,6 +113,15 @@ public LogicalType primitive(Type.PrimitiveType primitive
pvary commented on code in PR #11348:
URL: https://github.com/apache/iceberg/pull/11348#discussion_r1812930067
##
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/data/FlinkParquetReaders.java:
##
@@ -411,6 +416,43 @@ public DecimalData read(DecimalData ignored) {
}
pvary commented on code in PR #11348:
URL: https://github.com/apache/iceberg/pull/11348#discussion_r1812947524
##
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/source/reader/TestColumnStatsWatermarkExtractorNano.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache
pvary commented on PR #11348:
URL: https://github.com/apache/iceberg/pull/11348#issuecomment-2432497304
There are several tests which are using `DataGenerator` to generate test
data - do we want to add nanos to them?
--
This is an automated message from the Apache Git Service.
To respond
pvary commented on code in PR #11348:
URL: https://github.com/apache/iceberg/pull/11348#discussion_r1812930067
##
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/data/FlinkParquetReaders.java:
##
@@ -411,6 +416,43 @@ public DecimalData read(DecimalData ignored) {
}
pvary commented on code in PR #11348:
URL: https://github.com/apache/iceberg/pull/11348#discussion_r1812936226
##
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/data/FlinkParquetReaders.java:
##
@@ -411,6 +416,43 @@ public DecimalData read(DecimalData ignored) {
}
pvary commented on code in PR #11348:
URL: https://github.com/apache/iceberg/pull/11348#discussion_r1812916340
##
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/TypeToFlinkType.java:
##
@@ -113,6 +113,15 @@ public LogicalType primitive(Type.PrimitiveType primitive)
{
rodmeneses commented on PR #11348:
URL: https://github.com/apache/iceberg/pull/11348#issuecomment-2430505790
> Do the schema conversions handle the nano ts correctly? Do we get a
`Timestamp(9)` when we convert to Flink schema, or a nano timestamp when we
convert from the Iceberg schema?
12 matches
Mail list logo
