pvary commented on code in PR #11348:
URL: https://github.com/apache/iceberg/pull/11348#discussion_r1812916340
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/TypeToFlinkType.java:
##########
@@ -113,6 +113,15 @@ public LogicalType primitive(Type.PrimitiveType primitive)
{
// MICROS
return new TimestampType(6);
}
+ case TIMESTAMP_NANO:
+ Types.TimestampNanoType timestampNano = (Types.TimestampNanoType)
primitive;
+ if (timestampNano.shouldAdjustToUTC()) {
+ // NANOS
Review Comment:
Why is this comment?
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/TypeToFlinkType.java:
##########
@@ -113,6 +113,15 @@ public LogicalType primitive(Type.PrimitiveType primitive)
{
// MICROS
return new TimestampType(6);
}
+ case TIMESTAMP_NANO:
+ Types.TimestampNanoType timestampNano = (Types.TimestampNanoType)
primitive;
+ if (timestampNano.shouldAdjustToUTC()) {
+ // NANOS
+ return new LocalZonedTimestampType(9);
+ } else {
+ // NANOS
Review Comment:
Pls. remove the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
