pvary commented on PR #11018:
URL: https://github.com/apache/iceberg/pull/11018#issuecomment-2322156392
Merged to main. Thanks for the backport @zhongqishang!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
pvary merged PR #11018:
URL: https://github.com/apache/iceberg/pull/11018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
zhongqishang commented on code in PR #11018:
URL: https://github.com/apache/iceberg/pull/11018#discussion_r1732440361
##
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergFilesCommitter.java:
##
@@ -242,21 +246,21 @@ public void testOrderedEventsBetweenChe
pvary commented on code in PR #11018:
URL: https://github.com/apache/iceberg/pull/11018#discussion_r1732412465
##
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergFilesCommitter.java:
##
@@ -242,21 +246,21 @@ public void testOrderedEventsBetweenCheckpoint
zhongqishang commented on PR #11018:
URL: https://github.com/apache/iceberg/pull/11018#issuecomment-2311773163
I via the follow cmd to check the diff
```
git diff --no-index
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/sink
flink/v1.20/flink/src/main/java/org/apach
zhongqishang commented on code in PR #11018:
URL: https://github.com/apache/iceberg/pull/11018#discussion_r1732277405
##
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergFilesCommitter.java:
##
@@ -242,21 +246,21 @@ public void testOrderedEventsBetweenChe
pvary commented on PR #11018:
URL: https://github.com/apache/iceberg/pull/11018#issuecomment-2311663370
@zhongqishang:
This could help with the backport:
```
git diff HEAD^ HEAD > /tmp/v1.19.patch
cat /tmp/v1.19.patch | sed "s/v1.19/v1.20/g" > /tmp/v1.20.patch
git apply -3 /tmp
