zhongqishang commented on code in PR #11018:
URL: https://github.com/apache/iceberg/pull/11018#discussion_r1732440361


##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergFilesCommitter.java:
##########
@@ -242,21 +246,21 @@ public void testOrderedEventsBetweenCheckpoints() throws 
Exception {
       RowData row1 = SimpleDataUtil.createRowData(1, "hello");
       DataFile dataFile1 = writeDataFile("data-1", ImmutableList.of(row1));
 
-      harness.processElement(of(dataFile1), ++timestamp);
+      long firstCheckpointId = 1;
+      harness.processElement(of(firstCheckpointId, dataFile1), ++timestamp);

Review Comment:
   
https://github.com/apache/iceberg/commit/e6f8ab9950267c18734ba0cb2ce29867790e24fe#diff-4f79d5342dad9de47d561297e1af60aac21a498f22144ad378dc762affdbfa27L142-L143
   
   Yes, thanks for your reminder.
   It should be the modification of `TestIcebergFilesCommitter.java` that 
caused the inconsistent line numbers.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to