Fokko commented on code in PR #965:
URL: https://github.com/apache/iceberg-python/pull/965#discussion_r1709259368
##
tests/expressions/test_parser.py:
##
@@ -199,3 +199,7 @@ def test_with_function() -> None:
parser.parse("foo = 1 and lower(bar) = '2'")
assert "Ex
Fokko commented on code in PR #965:
URL: https://github.com/apache/iceberg-python/pull/965#discussion_r1709259368
##
tests/expressions/test_parser.py:
##
@@ -199,3 +199,7 @@ def test_with_function() -> None:
parser.parse("foo = 1 and lower(bar) = '2'")
assert "Ex
Fokko commented on code in PR #965:
URL: https://github.com/apache/iceberg-python/pull/965#discussion_r1707389618
##
tests/expressions/test_parser.py:
##
@@ -199,3 +199,7 @@ def test_with_function() -> None:
parser.parse("foo = 1 and lower(bar) = '2'")
assert "Ex
Fokko commented on code in PR #965:
URL: https://github.com/apache/iceberg-python/pull/965#discussion_r1707389618
##
tests/expressions/test_parser.py:
##
@@ -199,3 +199,7 @@ def test_with_function() -> None:
parser.parse("foo = 1 and lower(bar) = '2'")
assert "Ex
Fokko commented on code in PR #965:
URL: https://github.com/apache/iceberg-python/pull/965#discussion_r1707383378
##
pyiceberg/io/pyarrow.py:
##
@@ -572,51 +572,54 @@ def _convert_scalar(value: Any, iceberg_type:
IcebergType) -> pa.scalar:
class _ConvertToArrowExpression(B
kevinjqliu commented on PR #965:
URL: https://github.com/apache/iceberg-python/pull/965#issuecomment-2253288619
> Unfortunately, I think this means that the scale of this problem is larger
than a simple bug fix onto the Expression parser, expression_to_pyarrow and the
Reference classes.
sungwy commented on PR #965:
URL: https://github.com/apache/iceberg-python/pull/965#issuecomment-2253221462
@kevinjqliu - I've given this a bit more thought, and if we are looking to
use `.` to represent nested fields, we will always run into an issue with `.`
named fields if we split based
sungwy commented on PR #965:
URL: https://github.com/apache/iceberg-python/pull/965#issuecomment-2253134748
> Since we're using the `.` character to represent nested access, what if I
have a column named `foo.bar`? Can we add a test case for that?
Thank you for the suggestion! This te
kevinjqliu commented on code in PR #965:
URL: https://github.com/apache/iceberg-python/pull/965#discussion_r1693317596
##
pyiceberg/expressions/parser.py:
##
@@ -83,7 +83,7 @@
@column.set_parse_action
def _(result: ParseResults) -> Reference:
-return Reference(result.col
sungwy opened a new pull request, #965:
URL: https://github.com/apache/iceberg-python/pull/965
Fixes: https://github.com/apache/iceberg-python/issues/953
This may be a backward incompatible change because it seemingly removes
support for allowing the table name within the parser strin
10 matches
Mail list logo
