kevinjqliu commented on code in PR #965: URL: https://github.com/apache/iceberg-python/pull/965#discussion_r1693317596
########## pyiceberg/expressions/parser.py: ########## @@ -83,7 +83,7 @@ @column.set_parse_action def _(result: ParseResults) -> Reference: - return Reference(result.column[-1]) + return Reference(".".join(result.column)) Review Comment: nit: extract out `"."` as a variable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org