rdblue merged PR #12144:
URL: https://github.com/apache/iceberg/pull/12144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
Fokko commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1944385584
##
gcp-bundle/LICENSE:
##
@@ -549,7 +537,73 @@ License: Apache 2 -
https://www.apache.org/licenses/LICENSE-2.0
Fokko commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1944381778
##
gcp-bundle/LICENSE:
##
@@ -549,7 +537,73 @@ License: Apache 2 -
https://www.apache.org/licenses/LICENSE-2.0
jbonofre commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1944184374
##
gcp-bundle/LICENSE:
##
@@ -325,24 +315,30 @@ License: The Apache Software License, Version 2.0 -
http://www.apache.org/licens
---
jbonofre commented on PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#issuecomment-2636307784
@rdblue I think I addressed all comments. Can you please do a new pass ?
Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
jbonofre commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1942569220
##
gcp-bundle/LICENSE:
##
@@ -325,24 +315,24 @@ License: The Apache Software License, Version 2.0 -
http://www.apache.org/licens
Review Comment:
@amogh-jahagi
jbonofre commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1942562947
##
gcp-bundle/LICENSE:
##
@@ -220,100 +220,90 @@ License: Apache 2.0 -
http://www.apache.org/licenses/LICENSE-2.0
--
rdblue commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1941966254
##
gcp-bundle/LICENSE:
##
@@ -325,24 +315,30 @@ License: The Apache Software License, Version 2.0 -
http://www.apache.org/licens
-
rdblue commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1941966254
##
gcp-bundle/LICENSE:
##
@@ -325,24 +315,30 @@ License: The Apache Software License, Version 2.0 -
http://www.apache.org/licens
-
rdblue commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1941965760
##
gcp-bundle/LICENSE:
##
@@ -220,100 +220,90 @@ License: Apache 2.0 -
http://www.apache.org/licenses/LICENSE-2.0
rdblue commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1941964907
##
gcp-bundle/LICENSE:
##
@@ -325,24 +315,24 @@ License: The Apache Software License, Version 2.0 -
http://www.apache.org/licens
Review Comment:
The license of
jbonofre commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1941189127
##
gcp-bundle/LICENSE:
##
@@ -549,7 +537,50 @@ License: Apache 2 -
https://www.apache.org/licenses/LICENSE-2.0
-
jbonofre commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1941165133
##
gcp-bundle/LICENSE:
##
@@ -265,84 +265,78 @@ License: Apache-2.0 -
https://www.apache.org/licenses/LICENSE-2.0.txt
--
Fokko commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1941100042
##
gcp-bundle/LICENSE:
##
@@ -265,84 +265,78 @@ License: Apache-2.0 -
https://www.apache.org/licenses/LICENSE-2.0.txt
-
jbonofre commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938853753
##
gcp-bundle/LICENSE:
##
@@ -220,100 +220,90 @@ License: Apache 2.0 -
http://www.apache.org/licenses/LICENSE-2.0
--
jbonofre commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938786136
##
gcp-bundle/LICENSE:
##
@@ -220,100 +220,90 @@ License: Apache 2.0 -
http://www.apache.org/licenses/LICENSE-2.0
--
amogh-jahagirdar commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938632389
##
gcp-bundle/LICENSE:
##
@@ -220,100 +220,90 @@ License: Apache 2.0 -
http://www.apache.org/licenses/LICENSE-2.0
--
amogh-jahagirdar commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938632389
##
gcp-bundle/LICENSE:
##
@@ -220,100 +220,90 @@ License: Apache 2.0 -
http://www.apache.org/licenses/LICENSE-2.0
--
amogh-jahagirdar commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938632389
##
gcp-bundle/LICENSE:
##
@@ -220,100 +220,90 @@ License: Apache 2.0 -
http://www.apache.org/licenses/LICENSE-2.0
--
jbonofre commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938543535
##
gcp-bundle/LICENSE:
##
@@ -325,24 +315,24 @@ License: The Apache Software License, Version 2.0 -
http://www.apache.org/licens
Review Comment:
Done
--
T
jbonofre commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938536328
##
gcp-bundle/LICENSE:
##
@@ -325,24 +315,24 @@ License: The Apache Software License, Version 2.0 -
http://www.apache.org/licens
Review Comment:
I agree. Let
amogh-jahagirdar commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938533960
##
gcp-bundle/LICENSE:
##
@@ -325,24 +315,24 @@ License: The Apache Software License, Version 2.0 -
http://www.apache.org/licens
Review Comment:
Sure,
jbonofre commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938423547
##
gcp-bundle/LICENSE:
##
@@ -325,24 +315,24 @@ License: The Apache Software License, Version 2.0 -
http://www.apache.org/licens
Review Comment:
Yes, it's wha
amogh-jahagirdar commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938393559
##
gcp-bundle/LICENSE:
##
@@ -325,24 +315,24 @@ License: The Apache Software License, Version 2.0 -
http://www.apache.org/licens
Review Comment:
Findb
jbonofre commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938000804
##
gcp-bundle/NOTICE:
##
@@ -29,72 +29,225 @@ from the source code management (SCM) system project uses.
jbonofre commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938006639
##
gcp-bundle/LICENSE:
##
@@ -203,11 +203,11 @@
-This binary artifact contains
jbonofre commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938006481
##
gcp-bundle/NOTICE:
##
@@ -29,72 +29,225 @@ from the source code management (SCM) system project uses.
jbonofre commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938005618
##
gcp-bundle/LICENSE:
##
@@ -325,24 +315,24 @@ License: The Apache Software License, Version 2.0 -
http://www.apache.org/licens
Review Comment:
Which one ? N
jbonofre commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1938004031
##
gcp-bundle/LICENSE:
##
@@ -203,11 +203,11 @@
-This binary artifact contains
jbonofre commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r193763
##
gcp-bundle/LICENSE:
##
@@ -220,100 +220,90 @@ License: Apache 2.0 -
http://www.apache.org/licenses/LICENSE-2.0
--
rdblue commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1937804042
##
gcp-bundle/LICENSE:
##
@@ -325,24 +315,24 @@ License: The Apache Software License, Version 2.0 -
http://www.apache.org/licens
Review Comment:
We need to supp
rdblue commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1937804042
##
gcp-bundle/LICENSE:
##
@@ -325,24 +315,24 @@ License: The Apache Software License, Version 2.0 -
http://www.apache.org/licens
Review Comment:
We need to supp
rdblue commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1937801941
##
gcp-bundle/NOTICE:
##
@@ -29,72 +29,225 @@ from the source code management (SCM) system project uses.
--
rdblue commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1937801153
##
gcp-bundle/LICENSE:
##
@@ -220,100 +220,90 @@ License: Apache 2.0 -
http://www.apache.org/licenses/LICENSE-2.0
34 matches
Mail list logo