Fokko commented on code in PR #12144:
URL: https://github.com/apache/iceberg/pull/12144#discussion_r1941100042


##########
gcp-bundle/LICENSE:
##########
@@ -265,84 +265,78 @@ License: Apache-2.0 - 
https://www.apache.org/licenses/LICENSE-2.0.txt
 
 
--------------------------------------------------------------------------------
 
-Group: com.google.api.grpc  Name: proto-google-common-protos  Version: 2.21.0
+Group: com.google.api.grpc  Name: proto-google-common-protos  Version: 2.50.1
 Project URL: https://github.com/googleapis/sdk-platform-java
 License: Apache-2.0 - https://www.apache.org/licenses/LICENSE-2.0.txt
 
 
--------------------------------------------------------------------------------
 
-Group: com.google.api.grpc  Name: proto-google-iam-v1  Version: 1.16.0
+Group: com.google.api.grpc  Name: proto-google-iam-v1  Version: 1.45.1
 Project URL: https://github.com/googleapis/sdk-platform-java
 License: Apache-2.0 - https://www.apache.org/licenses/LICENSE-2.0.txt
 
 
--------------------------------------------------------------------------------
 
-Group: com.google.apis  Name: google-api-services-storage  Version: 
v1-rev20230301-2.0.0
+Group: com.google.apis  Name: google-api-services-storage  Version: 
v1-rev20241206-2.0.0
 License: The Apache Software License, Version 2.0 - 
http://www.apache.org/licenses/LICENSE-2.0.txt
 
 
--------------------------------------------------------------------------------
 
-Group: com.google.auth  Name: google-auth-library-credentials  Version: 1.18.0
+Group: com.google.auth  Name: google-auth-library-credentials  Version: 1.30.1
 License: BSD New license - http://opensource.org/licenses/BSD-3-Clause
 
 
--------------------------------------------------------------------------------
 
-Group: com.google.auth  Name: google-auth-library-oauth2-http  Version: 1.18.0
+Group: com.google.auth  Name: google-auth-library-oauth2-http  Version: 1.30.1
 License: BSD New license - http://opensource.org/licenses/BSD-3-Clause
 
 
--------------------------------------------------------------------------------
 
-Group: com.google.auto.value  Name: auto-value-annotations  Version: 1.10.1
+Group: com.google.auto.value  Name: auto-value-annotations  Version: 1.11.0
 Project URL: https://github.com/google/auto/tree/master/value
 License: Apache 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt
 
 
--------------------------------------------------------------------------------
 
-Group: com.google.cloud  Name: google-cloud-core  Version: 2.20.0
+Group: com.google.cloud  Name: google-cloud-core  Version: 2.49.1
 License: Apache-2.0 - https://www.apache.org/licenses/LICENSE-2.0.txt
 
 
--------------------------------------------------------------------------------
 
-Group: com.google.cloud  Name: google-cloud-core-grpc  Version: 2.20.0
+Group: com.google.cloud  Name: google-cloud-core-grpc  Version: 2.49.1
 License: Apache-2.0 - https://www.apache.org/licenses/LICENSE-2.0.txt
 
 
--------------------------------------------------------------------------------
 
-Group: com.google.cloud  Name: google-cloud-core-http  Version: 2.20.0
+Group: com.google.cloud  Name: google-cloud-core-http  Version: 2.49.1
 License: Apache-2.0 - https://www.apache.org/licenses/LICENSE-2.0.txt
 
 
--------------------------------------------------------------------------------
 
-Group: com.google.cloud  Name: google-cloud-storage  Version: 2.22.5
+Group: com.google.cloud  Name: google-cloud-storage  Version: 2.47.0
 Project URL: https://github.com/googleapis/java-storage
 License: Apache-2.0 - https://www.apache.org/licenses/LICENSE-2.0.txt
 
 
--------------------------------------------------------------------------------
 
-Group: com.google.code.findbugs  Name: jsr305  Version: 3.0.2

Review Comment:
   I'm still seeing some traces of `findbugs`, let's see if we can remove this 
in another PR:
   
   ```
   find . | grep "findbugs"            
   ./META-INF/maven/com.google.code.findbugs
   ./META-INF/maven/com.google.code.findbugs/jsr305
   ./META-INF/maven/com.google.code.findbugs/jsr305/pom.xml
   ./META-INF/maven/com.google.code.findbugs/jsr305/pom.properties
   ```



##########
gcp-bundle/LICENSE:
##########
@@ -549,7 +537,50 @@ License: Apache 2 - 
https://www.apache.org/licenses/LICENSE-2.0
 
 
--------------------------------------------------------------------------------
 
-Group: org.threeten  Name: threetenbp  Version: 1.6.8
+Group: org.threeten  Name: threetenbp  Version: 1.7.8
 Project URL: https://www.threeten.org
 Project URL: https://www.threeten.org/threetenbp
 License: BSD-3-Clause - 
https://raw.githubusercontent.com/ThreeTen/threetenbp/main/LICENSE.txt
+
+--------------------------------------------------------------------------------

Review Comment:
   Using `./gradlew :iceberg-gcp-bundle:dependencies` and some regex, I'll end 
up with:
   ```
   io.opentelemetry.contrib:opentelemetry-gcp-resources:1.37.0-alpha 
io.opentelemetry.semconv:opentelemetry-semconv:1.27.0-alpha
   io.opentelemetry:opentelemetry-api-incubator:1.45.0-alpha
   io.opentelemetry:opentelemetry-api:1.45.0
   io.opentelemetry:opentelemetry-bom:1.42.1
   io.opentelemetry:opentelemetry-context:1.42.1 -> 1.45.0 (c)
   io.opentelemetry:opentelemetry-context:1.45.0
   io.opentelemetry:opentelemetry-sdk-common:1.42.1 -> 1.45.0 (c)
   io.opentelemetry:opentelemetry-sdk-common:1.45.0
   io.opentelemetry:opentelemetry-sdk-extension-autoconfigure-spi:1.42.1 -> 
1.45.0 (c)
   io.opentelemetry:opentelemetry-sdk-extension-autoconfigure-spi:1.45.0
   io.opentelemetry:opentelemetry-sdk-logs:1.42.1 -> 1.45.0 (c)
   io.opentelemetry:opentelemetry-sdk-logs:1.45.0
   io.opentelemetry:opentelemetry-sdk-metrics:1.45.0
   io.opentelemetry:opentelemetry-sdk-trace:1.42.1 -> 1.45.0 (c)
   io.opentelemetry:opentelemetry-sdk-trace:1.45.0
   io.opentelemetry:opentelemetry-sdk:1.42.1 -> 1.45.0 (c)
   io.opentelemetry:opentelemetry-sdk:1.45.0
   ```
   
   It looks like the following are missing: 
   
   
   ```
   io.opentelemetry.contrib:opentelemetry-gcp-resources:1.37.0-alpha
   io.opentelemetry.semconv:opentelemetry-semconv:1.27.0-alpha
   io.opentelemetry:opentelemetry-api-incubator:1.45.0-alpha
   io.opentelemetry:opentelemetry-bom:1.42.1
   io.opentelemetry:opentelemetry-sdk-metrics:1.45.0
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to