Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2998504785 Hey @Fokko I have resolved all conflicts and merged the recent changes. While running integration tests, I am facing this error for a few tests: ``` java.lang.IllegalSt

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r2162799415 ## pyiceberg/table/__init__.py: ## @@ -774,12 +797,24 @@ def upsert( matched_predicate = upsert_util.create_match_filter(df, join_cols) # We mus

Re: [PR] Feature: Write to branches [iceberg-python]

SebastienN15 commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2996823009 Hey @vinjai, would you be able to resolve the conflicts? I would love to see this PR merged 🙏 -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] Feature: Write to branches [iceberg-python]

Fokko commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2984589654 @vinjai I'm sorry, can you resolve the conflicts once more? I'll merge right after -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Feature: Write to branches [iceberg-python]

Fokko commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r2154822875 ## pyiceberg/table/__init__.py: ## @@ -635,15 +651,18 @@ def delete( if isinstance(delete_filter, str): delete_filter = _parse_row_filter(delet

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2934314266 Hey @Fokko I've pulled the latest changes from the main branch. Please re-trigger the workflow. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Feature: Write to branches [iceberg-python]

Fokko commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2927779254 @vinjai Thanks for pinging me. The issue has been fixed in https://github.com/apache/iceberg-python/pull/2049. Locally, you're still using an older version of minio, and therefore the

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2927518910 Hey @Fokko I noticed that the integration tests for Python 3.9 are failing. Possibly, a runtime issue: ```shell ServerError: NoSuchBucketException: The specified bucket

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2912737391 Hey @Fokko This PR is ready for review again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2908486545 Identified and fixed a bug related to empty tables. Planning to add test cases to cover this scenario. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2904799400 Thanks @SebastienN15 — I’ll review your commit and take it forward from there. I’ll share the working PR tomorrow. -- This is an automated message from the Apache Git Service. T

Re: [PR] Feature: Write to branches [iceberg-python]

SebastienN15 commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2871450035 Hey @vinjai, did you get a chance to fix those conflicts? 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2836376523 Hey @Fokko Will try to resolve the conflicts over the weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Feature: Write to branches [iceberg-python]

Fokko commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2828736306 Thanks @dbuades for pinging me, and sorry for letting this one linger for so long. Let me review this tomorrow morning. @vinjai Do you have time to resolve the conflicts by any c

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2754750370 Hey @kevinjqliu Bumping up for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Feature: Write to branches [iceberg-python]

malcolmbovey commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2745126233 Hi, just wondering if there is an update on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2708059145 Hey @kevinjqliu Did you get a chance to look at the PR again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2677114643 Hey @kevinjqliu I have resolved all comments. Will resolve the merge conflicts once you have gone through these changes (to avoid rework). Let me know once you have revie

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1966883670 ## tests/table/test_init.py: ## @@ -982,28 +982,43 @@ def test_assert_table_uuid(table_v2: Table) -> None: def test_assert_ref_snapshot_id(table_v2: Table) -> No

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1966882693 ## pyiceberg/table/__init__.py: ## @@ -1003,22 +1015,27 @@ def overwrite( overwrite_filter: ALWAYS_TRUE when you overwrite all the data,

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1966881022 ## tests/table/test_init.py: ## @@ -982,28 +982,43 @@ def test_assert_table_uuid(table_v2: Table) -> None: def test_assert_ref_snapshot_id(table_v2: Table) -> No

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1966876035 ## tests/integration/test_writes/test_writes.py: ## @@ -1570,3 +1572,158 @@ def test_abort_table_transaction_on_exception( # Validate the transaction is abor

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1966875880 ## pyiceberg/table/update/__init__.py: ## @@ -609,11 +609,14 @@ class AssertRefSnapshotId(ValidatableTableRequirement): type: Literal["assert-ref-snapshot-id

Re: [PR] Feature: Write to branches [iceberg-python]

kevinjqliu commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2629019931 thank you! @vinjai feel free to tag me again for review :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2628949861 Hey @kevinjqliu I was traveling for the past two months and couldn’t complete the review comments. I’ll be back in a week, will address the comments then, and get this moving.

Re: [PR] Feature: Write to branches [iceberg-python]

kevinjqliu commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2628614211 hey @vinjai are you interested to pick this back up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Feature: Write to branches [iceberg-python]

kevinjqliu commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1866354514 ## pyiceberg/table/update/__init__.py: ## @@ -609,11 +609,14 @@ class AssertRefSnapshotId(ValidatableTableRequirement): type: Literal["assert-ref-snapsho

Re: [PR] Feature: Write to branches [iceberg-python]

kevinjqliu commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1866358508 ## tests/table/test_init.py: ## @@ -982,28 +982,43 @@ def test_assert_table_uuid(table_v2: Table) -> None: def test_assert_ref_snapshot_id(table_v2: Table) -

Re: [PR] Feature: Write to branches [iceberg-python]

kevinjqliu commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2512331585 @vinjai coming back to this after the 0.8.1 release :) Feel free to tag me again once the comments above are addressed. Thanks again for the contribution! -- This is an aut

Re: [PR] Feature: Write to branches [iceberg-python]

kevinjqliu commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1866359013 ## tests/table/test_init.py: ## @@ -982,28 +982,43 @@ def test_assert_table_uuid(table_v2: Table) -> None: def test_assert_ref_snapshot_id(table_v2: Table) -

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1865177262 ## tests/table/test_init.py: ## @@ -982,28 +982,43 @@ def test_assert_table_uuid(table_v2: Table) -> None: def test_assert_ref_snapshot_id(table_v2: Table) -> No

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1865176166 ## tests/table/test_init.py: ## @@ -982,28 +982,43 @@ def test_assert_table_uuid(table_v2: Table) -> None: def test_assert_ref_snapshot_id(table_v2: Table) -> No

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1855301400 ## tests/table/test_init.py: ## @@ -982,28 +982,43 @@ def test_assert_table_uuid(table_v2: Table) -> None: def test_assert_ref_snapshot_id(table_v2: Table) -> No

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1855299774 ## pyiceberg/table/update/__init__.py: ## @@ -609,11 +609,14 @@ class AssertRefSnapshotId(ValidatableTableRequirement): type: Literal["assert-ref-snapshot-id

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1855299357 ## pyiceberg/table/__init__.py: ## @@ -1003,22 +1015,27 @@ def overwrite( overwrite_filter: ALWAYS_TRUE when you overwrite all the data,

Re: [PR] Feature: Write to branches [iceberg-python]

kevinjqliu commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2491889472 cc @HonahX / @Fokko / @sungwy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Feature: Write to branches [iceberg-python]

kevinjqliu commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1852553109 ## tests/table/test_init.py: ## @@ -982,28 +982,43 @@ def test_assert_table_uuid(table_v2: Table) -> None: def test_assert_ref_snapshot_id(table_v2: Table) -

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2487692994 @kevinjqliu What are the next steps to get this merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Feature: Write to branches [iceberg-python]

MChamberlin commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2483824116 @kevinjqliu Is there anyway this can be included in the 0.8.0 release? This is an important feature add with only relatively simple refactoring. -- This is an automated message

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1841381304 ## tests/integration/test_writes/test_writes.py: ## @@ -1448,3 +1450,100 @@ def test_rewrite_manifest_after_partition_evolution(session_catalog: Catalog) ->

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2475142299 Thank you for the review @kevinjqliu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1841381304 ## tests/integration/test_writes/test_writes.py: ## @@ -1448,3 +1450,100 @@ def test_rewrite_manifest_after_partition_evolution(session_catalog: Catalog) ->

Re: [PR] Feature: Write to branches [iceberg-python]

kevinjqliu commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1835751569 ## tests/integration/test_writes/test_writes.py: ## @@ -1448,3 +1450,100 @@ def test_rewrite_manifest_after_partition_evolution(session_catalog: Catalog) ->

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2463348171 Hey @kevinjqliu Did you get a chance to look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2424158737 I have mostly tried to cover all edge cases. The idea is that the branch is just another iceberg table where the snapshots append independently of the main branch. I also agr

Re: [PR] Feature: Write to branches [iceberg-python]

kevinjqliu commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2424130438 Thanks for the contribution! I'll take a look. I remember adding support for branch is complicated since we need to consider different edge cases. -- This is an automated m

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2417891570 Fixed another bug. Writes with same name but different ref types Please review whenever you get some time. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2416056139 @sungwy @kevinjqliu This PR is ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Feature: Write to branches [iceberg-python]

vinjai commented on PR #941: URL: https://github.com/apache/iceberg-python/pull/941#issuecomment-2416055849 @sungwy @kevinjqliu This PR is ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab