vinjai commented on code in PR #941: URL: https://github.com/apache/iceberg-python/pull/941#discussion_r1855299357
########## pyiceberg/table/__init__.py: ########## @@ -1003,22 +1015,27 @@ def overwrite( overwrite_filter: ALWAYS_TRUE when you overwrite all the data, or a boolean expression in case of a partial overwrite snapshot_properties: Custom properties to be added to the snapshot summary + branch: Branch Reference to run the delete operation Review Comment: My bad. Missed it!! We can actually go with the generic one as the `operation` is always going to be part of the method name. Will make the change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org