Re: [PR] Document procedure for stats collection [iceberg]

2024-12-04 Thread via GitHub
szehon-ho commented on PR #11606: URL: https://github.com/apache/iceberg/pull/11606#issuecomment-2518698155 Merged, thanks @karuppayya and @RussellSpitzer , @manuzhang for addition review -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Document procedure for stats collection [iceberg]

2024-12-04 Thread via GitHub
szehon-ho merged PR #11606: URL: https://github.com/apache/iceberg/pull/11606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Document procedure for stats collection [iceberg]

2024-12-04 Thread via GitHub
szehon-ho commented on PR #11606: URL: https://github.com/apache/iceberg/pull/11606#issuecomment-2518342742 Thanks @karuppayya for the patience, it looks good to me, I will merge it later today if no more comments. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Document procedure for stats collection [iceberg]

2024-12-04 Thread via GitHub
szehon-ho commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1870121905 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||-

Re: [PR] Document procedure for stats collection [iceberg]

2024-12-04 Thread via GitHub
szehon-ho commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1870121070 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||-

Re: [PR] Document procedure for stats collection [iceberg]

2024-12-03 Thread via GitHub
szehon-ho commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1868637948 ## docs/docs/spark-procedures.md: ## @@ -937,7 +937,7 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: | 3 | Robert | UPDATE_BE

Re: [PR] Document procedure for stats collection [iceberg]

2024-12-03 Thread via GitHub
szehon-ho commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1868409126 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||-

Re: [PR] Document procedure for stats collection [iceberg]

2024-12-02 Thread via GitHub
szehon-ho commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1866644046 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||-

Re: [PR] Document procedure for stats collection [iceberg]

2024-11-25 Thread via GitHub
karuppayya commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1857170703 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||

Re: [PR] Document procedure for stats collection [iceberg]

2024-11-25 Thread via GitHub
RussellSpitzer commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1856911925 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||

Re: [PR] Document procedure for stats collection [iceberg]

2024-11-24 Thread via GitHub
manuzhang commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1855696945 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||-

Re: [PR] Document procedure for stats collection [iceberg]

2024-11-24 Thread via GitHub
manuzhang commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1855691038 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||-

Re: [PR] Document procedure for stats collection [iceberg]

2024-11-24 Thread via GitHub
szehon-ho commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1855513995 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||-

Re: [PR] Document procedure for stats collection [iceberg]

2024-11-24 Thread via GitHub
RussellSpitzer commented on PR #11606: URL: https://github.com/apache/iceberg/pull/11606#issuecomment-2496041028 That would mean documenting it in the method itself not the description of the return value On Sun, Nov 24, 2024 at 2:33 AM Manu Zhang ***@***.***> wrote: > ***@**

Re: [PR] Document procedure for stats collection [iceberg]

2024-11-24 Thread via GitHub
manuzhang commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1855394563 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||-

Re: [PR] Document procedure for stats collection [iceberg]

2024-11-23 Thread via GitHub
RussellSpitzer commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1855332823 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||

Re: [PR] Document procedure for stats collection [iceberg]

2024-11-23 Thread via GitHub
RussellSpitzer commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1855332823 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||

Re: [PR] Document procedure for stats collection [iceberg]

2024-11-23 Thread via GitHub
manuzhang commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1855205570 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||-

Re: [PR] Document procedure for stats collection [iceberg]

2024-11-22 Thread via GitHub
szehon-ho commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1855135154 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||-

Re: [PR] Document procedure for stats collection [iceberg]

2024-11-22 Thread via GitHub
karuppayya commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1854799006 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||

Re: [PR] Document procedure for stats collection [iceberg]

2024-11-21 Thread via GitHub
szehon-ho commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1853410841 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||-

Re: [PR] Document procedure for stats collection [iceberg]

2024-11-21 Thread via GitHub
manuzhang commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1853228696 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||-

Re: [PR] Document procedure for stats collection [iceberg]

2024-11-20 Thread via GitHub
manuzhang commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1851183453 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||-

Re: [PR] Document procedure for stats collection [iceberg]

2024-11-20 Thread via GitHub
manuzhang commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1851182827 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||-

Re: [PR] Document procedure for stats collection [iceberg]

2024-11-20 Thread via GitHub
RussellSpitzer commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1850903860 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||

Re: [PR] Document procedure for stats collection [iceberg]

2024-11-20 Thread via GitHub
RussellSpitzer commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1850905717 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||

Re: [PR] Document procedure for stats collection [iceberg]

2024-11-20 Thread via GitHub
RussellSpitzer commented on code in PR #11606: URL: https://github.com/apache/iceberg/pull/11606#discussion_r1850902295 ## docs/docs/spark-procedures.md: ## @@ -936,3 +936,40 @@ as an `UPDATE_AFTER` image, resulting in the following pre/post update images: |-||

[PR] Document procedure for stats collection [iceberg]

2024-11-20 Thread via GitHub
karuppayya opened a new pull request, #11606: URL: https://github.com/apache/iceberg/pull/11606 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,