RussellSpitzer commented on PR #11606: URL: https://github.com/apache/iceberg/pull/11606#issuecomment-2496041028
That would mean documenting it in the method itself not the description of the return value On Sun, Nov 24, 2024 at 2:33 AM Manu Zhang ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In docs/docs/spark-procedures.md > <https://github.com/apache/iceberg/pull/11606#discussion_r1855394563>: > > > + > +This procedure calculates the Number of Distinct Values (NDV) statistics for a specified table. > +By default, statistics are computed for all columns using the table's current snapshot. > +The procedure can be optionally configured to compute statistics for a specific snapshot and/or a subset of columns. > + > +| Argument Name | Required? | Type | Description | > +|---------------|-----------|---------------|-------------------------------------| > +| `table` | ✔️ | string | Name of the table | > +| `snapshot_id` | | string | id of the snapshot to collect stats | > +| `columns` | | array<string> | columns to collect stats | > + > +#### Output > + > +| Output Name | Type | Description | > +|-------------------|--------|-------------------------------------------------| > +| `statistics_file` | string | path to stats file created from by this command | > > I'm not sure this returned value will be visible to users, for example, in > a cluster mode Spark application. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/iceberg/pull/11606#discussion_r1855394563>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AADE2YODS73PPPNK5KFKI7D2CGFL3AVCNFSM6AAAAABSFLSGV6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINJWGY2TGMZUGE> > . > You are receiving this because you commented.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
