Re: [PR] Docs: Update defaults for distribution mode [iceberg]

2024-07-16 Thread via GitHub
szehon-ho merged PR #10575: URL: https://github.com/apache/iceberg/pull/10575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Docs: Update defaults for distribution mode [iceberg]

2024-07-16 Thread via GitHub
szehon-ho commented on PR #10575: URL: https://github.com/apache/iceberg/pull/10575#issuecomment-2231816905 Thanks @RussellSpitzer @dramaticlly @ajantha-bhat for reviews! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Docs: Update defaults for distribution mode [iceberg]

2024-07-16 Thread via GitHub
RussellSpitzer commented on PR #10575: URL: https://github.com/apache/iceberg/pull/10575#issuecomment-2231805898 Looks good to me now. :) Feel free to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Docs: Update defaults for distribution mode [iceberg]

2024-07-16 Thread via GitHub
szehon-ho commented on code in PR #10575: URL: https://github.com/apache/iceberg/pull/10575#discussion_r1680040372 ## docs/docs/spark-configuration.md: ## @@ -190,6 +190,7 @@ df.write | compression-codec | Table write.(fileformat).compression-codec | Overrides this table'

Re: [PR] Docs: Update defaults for distribution mode [iceberg]

2024-07-16 Thread via GitHub
RussellSpitzer commented on code in PR #10575: URL: https://github.com/apache/iceberg/pull/10575#discussion_r1679787603 ## docs/docs/spark-configuration.md: ## @@ -190,6 +190,7 @@ df.write | compression-codec | Table write.(fileformat).compression-codec | Overrides this t

Re: [PR] Docs: Update defaults for distribution mode [iceberg]

2024-07-16 Thread via GitHub
RussellSpitzer commented on code in PR #10575: URL: https://github.com/apache/iceberg/pull/10575#discussion_r1679784816 ## docs/docs/configuration.md: ## @@ -67,7 +67,7 @@ Iceberg tables support table properties to configure table behavior, like the de | write.metadata.metrics

Re: [PR] Docs: Update defaults for distribution mode [iceberg]

2024-07-16 Thread via GitHub
szehon-ho commented on PR #10575: URL: https://github.com/apache/iceberg/pull/10575#issuecomment-2231419741 @RussellSpitzer do you have time to take a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Docs: Update defaults for distribution mode [iceberg]

2024-07-12 Thread via GitHub
szehon-ho commented on code in PR #10575: URL: https://github.com/apache/iceberg/pull/10575#discussion_r1676206823 ## docs/docs/configuration.md: ## @@ -67,7 +67,7 @@ Iceberg tables support table properties to configure table behavior, like the de | write.metadata.metrics.colu

Re: [PR] Docs: Update defaults for distribution mode [iceberg]

2024-07-03 Thread via GitHub
dramaticlly commented on code in PR #10575: URL: https://github.com/apache/iceberg/pull/10575#discussion_r1664551015 ## docs/docs/configuration.md: ## @@ -67,7 +67,7 @@ Iceberg tables support table properties to configure table behavior, like the de | write.metadata.metrics.co