RussellSpitzer commented on code in PR #10575:
URL: https://github.com/apache/iceberg/pull/10575#discussion_r1679784816
##########
docs/docs/configuration.md:
##########
@@ -67,7 +67,7 @@ Iceberg tables support table properties to configure table
behavior, like the de
| write.metadata.metrics.column.col1 | (not set)
| Metrics mode for column 'col1' to allow per-column tuning; none,
counts, truncate(length), or full
|
| write.target-file-size-bytes | 536870912 (512 MB)
| Controls the size of files generated to target about this many bytes
|
| write.delete.target-file-size-bytes | 67108864 (64 MB)
| Controls the size of delete files generated to target about this many
bytes
|
-| write.distribution-mode | none
| Defines distribution of write data: __none__: don't shuffle rows;
__hash__: hash distribute by partition key ; __range__: range distribute by
partition key or sort key if table has an SortOrder |
+| write.distribution-mode | none. Engines may
override this default, for example
[Spark](spark-configuration.md#write-options) | Defines distribution of write
data: __none__: don't shuffle rows; __hash__: hash distribute by partition key
; __range__: range distribute by partition key or sort key if table has an
SortOrder |
Review Comment:
I didn't really like this description before, but I think the change is
good. Might be nice in a follow up to change this since it isn't clear what
"distribution of write data" is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
