Re: [PR] Docs: Refactor site navigation bar [iceberg]

stevenzwu merged PR #12289: URL: https://github.com/apache/iceberg/pull/12289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Docs: Refactor site navigation bar [iceberg]

stevenzwu commented on PR #12289: URL: https://github.com/apache/iceberg/pull/12289#issuecomment-2667052630 seems like we have enough approvals. I am going to merge this. any other changes can be followed up separately. -- This is an automated message from the Apache Git Service. To

Re: [PR] Docs: Refactor site navigation bar [iceberg]

kevinjqliu commented on code in PR #12289: URL: https://github.com/apache/iceberg/pull/12289#discussion_r1960145250 ## site/nav.yml: ## Review Comment: 👍 except for `concepts/catalog.md`, for which the content is merged into `site/docs/terms.md`, nothing else changed.

Re: [PR] Docs: Refactor site navigation bar [iceberg]

manuzhang commented on PR #12289: URL: https://github.com/apache/iceberg/pull/12289#issuecomment-2664583070 Screenshots of the website after the change ### Homepage ![CleanShot 2025-02-18 at 12 27 41@2x](https://github.com/user-attachments/assets/1ebc6bf9-949a-4e4b-97ca-42fba2ef93

Re: [PR] Docs: Refactor site navigation bar [iceberg]

stevenzwu commented on code in PR #12289: URL: https://github.com/apache/iceberg/pull/12289#discussion_r1958882598 ## site/docs/terms.md: ## @@ -20,39 +20,69 @@ title: "Terms" # Terms -### Snapshot +## Catalog Review Comment: agree that catalog is a term, which is good

Re: [PR] Docs: Refactor site navigation bar [iceberg]

manuzhang commented on code in PR #12289: URL: https://github.com/apache/iceberg/pull/12289#discussion_r1958850913 ## site/docs/terms.md: ## @@ -20,39 +20,69 @@ title: "Terms" # Terms -### Snapshot +## Catalog Review Comment: I agree catalogs deserve more details but ha

Re: [PR] Docs: Refactor site navigation bar [iceberg]

RussellSpitzer commented on PR #12289: URL: https://github.com/apache/iceberg/pull/12289#issuecomment-2663844717 I think this looks good, but I would request some screenshots of the changes on the PR to demonstrate the differences. I don't think they have to be kept up to date with the revi

Re: [PR] Docs: Refactor site navigation bar [iceberg]

RussellSpitzer commented on code in PR #12289: URL: https://github.com/apache/iceberg/pull/12289#discussion_r1958657989 ## site/nav.yml: ## @@ -43,21 +43,20 @@ nav: - Project: - Community: community.md - Contributing: contribute.md -- REST Catalog Spec: https:

Re: [PR] Docs: Refactor site navigation bar [iceberg]

stevenzwu commented on code in PR #12289: URL: https://github.com/apache/iceberg/pull/12289#discussion_r1958656548 ## site/docs/terms.md: ## @@ -20,39 +20,69 @@ title: "Terms" # Terms -### Snapshot +## Catalog Review Comment: I actually favor a little more on keeping `c

Re: [PR] Docs: Refactor site navigation bar [iceberg]

stevenzwu commented on code in PR #12289: URL: https://github.com/apache/iceberg/pull/12289#discussion_r1958653687 ## site/nav.yml: ## @@ -43,21 +43,20 @@ nav: - Project: - Community: community.md - Contributing: contribute.md -- REST Catalog Spec: https://edi

Re: [PR] Docs: Refactor site navigation bar [iceberg]

manuzhang commented on code in PR #12289: URL: https://github.com/apache/iceberg/pull/12289#discussion_r1957878334 ## site/nav.yml: ## @@ -43,21 +43,20 @@ nav: - Project: - Community: community.md - Contributing: contribute.md -- REST Catalog Spec: https://edi

Re: [PR] Docs: Refactor site navigation bar [iceberg]

manuzhang commented on code in PR #12289: URL: https://github.com/apache/iceberg/pull/12289#discussion_r1957878334 ## site/nav.yml: ## @@ -43,21 +43,20 @@ nav: - Project: - Community: community.md - Contributing: contribute.md -- REST Catalog Spec: https://edi

Re: [PR] Docs: Refactor site navigation bar [iceberg]

Fokko commented on code in PR #12289: URL: https://github.com/apache/iceberg/pull/12289#discussion_r1957828390 ## site/nav.yml: ## @@ -43,21 +43,20 @@ nav: - Project: - Community: community.md - Contributing: contribute.md -- REST Catalog Spec: https://editor-

Re: [PR] Docs: Refactor site navigation bar [iceberg]

Fokko commented on code in PR #12289: URL: https://github.com/apache/iceberg/pull/12289#discussion_r1957824425 ## site/docs/terms.md: ## @@ -20,39 +20,69 @@ title: "Terms" # Terms -### Snapshot +## Catalog Review Comment: I like this, the `catalog.md` was always a bit l

[PR] Docs: Refactor site navigation bar [iceberg]

manuzhang opened a new pull request, #12289: URL: https://github.com/apache/iceberg/pull/12289 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,