kevinjqliu commented on code in PR #12289: URL: https://github.com/apache/iceberg/pull/12289#discussion_r1960145250
########## site/nav.yml: ########## Review Comment: 👍 except for `concepts/catalog.md`, for which the content is merged into `site/docs/terms.md`, nothing else changed. The tabs are just moved around to under "Specification" ########## site/docs/terms.md: ########## @@ -20,39 +20,69 @@ title: "Terms" # Terms -### Snapshot +## Catalog Review Comment: nit: what about taking `Catalog` one level up? Currently its the first subtab under "Terms". Would it make sense to make it its on sub in "Specification"?  ########## site/nav.yml: ########## Review Comment: ok i also double checked that moving from one tab to another doesn't affect the URL. For example, "Table Spec" is moved from under "Project" to under "Specification", but the URL is still `/spec` 👍 ########## site/nav.yml: ########## Review Comment: the only URL that changed (removed) is `concepts/catalog` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
