Re: [PR] Docs: Add flinkVersion and flinkVersionMajor instead of hardcode [iceberg]

2024-06-18 Thread via GitHub
Fokko merged PR #10463: URL: https://github.com/apache/iceberg/pull/10463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Docs: Add flinkVersion and flinkVersionMajor instead of hardcode [iceberg]

2024-06-12 Thread via GitHub
manuzhang commented on code in PR #10463: URL: https://github.com/apache/iceberg/pull/10463#discussion_r1636767183 ## docs/docs/flink-ddl.md: ## @@ -146,7 +146,7 @@ CREATE TABLE `hive_catalog`.`default`.`sample` ( ) WITH ('format-version'='2'); ``` -Table create commands sup

Re: [PR] Docs: Add flinkVersion and flinkVersionMajor instead of hardcode [iceberg]

2024-06-12 Thread via GitHub
findepi commented on code in PR #10463: URL: https://github.com/apache/iceberg/pull/10463#discussion_r1636281141 ## docs/docs/flink-ddl.md: ## @@ -146,7 +146,7 @@ CREATE TABLE `hive_catalog`.`default`.`sample` ( ) WITH ('format-version'='2'); ``` -Table create commands suppo

Re: [PR] Docs: Add flinkVersion and flinkVersionMajor instead of hardcode [iceberg]

2024-06-11 Thread via GitHub
manuzhang commented on code in PR #10463: URL: https://github.com/apache/iceberg/pull/10463#discussion_r1634650624 ## docs/docs/flink.md: ## @@ -115,15 +115,15 @@ wget ${FLINK_CONNECTOR_URL}/${FLINK_CONNECTOR_PACKAGE}-${HIVE_VERSION}_${SCALA_V Install the Apache Flink dependen

Re: [PR] Docs: Add flinkVersion and flinkVersionMajor instead of hardcode [iceberg]

2024-06-11 Thread via GitHub
Fokko commented on code in PR #10463: URL: https://github.com/apache/iceberg/pull/10463#discussion_r1634624062 ## docs/docs/flink.md: ## @@ -115,15 +115,15 @@ wget ${FLINK_CONNECTOR_URL}/${FLINK_CONNECTOR_PACKAGE}-${HIVE_VERSION}_${SCALA_V Install the Apache Flink dependency u

Re: [PR] Docs: Add flinkVersion and flinkVersionMajor instead of hardcode [iceberg]

2024-06-10 Thread via GitHub
manuzhang commented on PR #10463: URL: https://github.com/apache/iceberg/pull/10463#issuecomment-2159626243 @pvary Links to javadocs, where `icebergVersion` is used, were previously ignored. Anyway, the linkcheck has been removed in #10404 -- This is an automated message from the Apac

Re: [PR] Docs: Add flinkVersion and flinkVersionMajor instead of hardcode [iceberg]

2024-06-10 Thread via GitHub
pvary commented on PR #10463: URL: https://github.com/apache/iceberg/pull/10463#issuecomment-2157713201 @manuzhang: Any idea why the tests are failing on the new values (`flinkVersion`, `flinkVersionMajor`), but they are not failing on `icebergVersion`? -- This is an automated message fr