Fokko commented on code in PR #10463:
URL: https://github.com/apache/iceberg/pull/10463#discussion_r1634624062
##########
docs/docs/flink.md:
##########
@@ -115,15 +115,15 @@ wget
${FLINK_CONNECTOR_URL}/${FLINK_CONNECTOR_PACKAGE}-${HIVE_VERSION}_${SCALA_V
Install the Apache Flink dependency using `pip`:
```python
-pip install apache-flink==1.16.2
+pip install apache-flink=={{ flinkVersion }}
```
Provide a `file://` path to the `iceberg-flink-runtime` jar, which can be
obtained by building the project and looking at
`<iceberg-root-dir>/flink-runtime/build/libs`, or downloading it from the
[Apache official
repository](https://repo.maven.apache.org/maven2/org/apache/iceberg/iceberg-flink-runtime/).
Third-party jars can be added to `pyflink` via:
- `env.add_jars("file:///my/jar/path/connector.jar")`
- `table_env.get_config().get_configuration().set_string("pipeline.jars",
"file:///my/jar/path/connector.jar")`
-This is also mentioned in the official
[docs](https://ci.apache.org/projects/flink/flink-docs-release-1.16/docs/dev/python/dependency_management/).
The example below uses `env.add_jars(..)`:
+This is also mentioned in the official
[docs](https://ci.apache.org/projects/flink/flink-docs-release-{{
flinkVersionMajor }}/docs/dev/python/dependency_management/). The example below
uses `env.add_jars(..)`:
```python
Review Comment:
@manuzhang can you `grep` 1.16 on this page? I see a few more occurrences
below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
