Re: [PR] Data: Allow classes of different packages to implement DeleteFilter [iceberg]

2024-10-15 Thread via GitHub
github-actions[bot] commented on PR #9352: URL: https://github.com/apache/iceberg/pull/9352#issuecomment-2415379427 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Data: Allow classes of different packages to implement DeleteFilter [iceberg]

2024-10-15 Thread via GitHub
github-actions[bot] closed pull request #9352: Data: Allow classes of different packages to implement DeleteFilter URL: https://github.com/apache/iceberg/pull/9352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Data: Allow classes of different packages to implement DeleteFilter [iceberg]

2024-01-02 Thread via GitHub
RussellSpitzer commented on PR #9352: URL: https://github.com/apache/iceberg/pull/9352#issuecomment-1874346597 This seem like two different issues attempted to being solved in 1 PR. Please Separate them. I think you also need to offer a much more detailed explanation of why you want to make

Re: [PR] Data: Allow classes of different packages to implement DeleteFilter [iceberg]

2024-01-02 Thread via GitHub
RussellSpitzer commented on code in PR #9352: URL: https://github.com/apache/iceberg/pull/9352#discussion_r1439676343 ## data/src/main/java/org/apache/iceberg/data/DeleteFilter.java: ## @@ -138,7 +138,7 @@ public void incrementDeleteCount() { counter.increment(); } -

Re: [PR] Data: Allow classes of different packages to implement DeleteFilter [iceberg]

2024-01-02 Thread via GitHub
RussellSpitzer commented on code in PR #9352: URL: https://github.com/apache/iceberg/pull/9352#discussion_r1439676088 ## core/src/main/java/org/apache/iceberg/util/DecimalUtil.java: ## @@ -31,7 +31,7 @@ private DecimalUtil() {} public static byte[] toReusedFixLengthBytes(

[PR] Data: Allow classes of different packages to implement DeleteFilter [iceberg]

2023-12-20 Thread via GitHub
leo-livis opened a new pull request, #9352: URL: https://github.com/apache/iceberg/pull/9352 Increase the flexibility of DeleteFilter #9351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe