RussellSpitzer commented on code in PR #9352: URL: https://github.com/apache/iceberg/pull/9352#discussion_r1439676088
########## core/src/main/java/org/apache/iceberg/util/DecimalUtil.java: ########## @@ -31,7 +31,7 @@ private DecimalUtil() {} public static byte[] toReusedFixLengthBytes( int precision, int scale, BigDecimal decimal, byte[] reuseBuf) { Preconditions.checkArgument( - decimal.scale() == scale, + decimal.scale() <= scale, Review Comment: Is this safe? It is re-use fix length bytes but in this case we aren't using all the bytes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org