emkornfield commented on PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#issuecomment-2251545950
> It looks good to me. Thanks !
>
> By the way, it would be also possible to update `.asf.yml` for "force" at
least one review. I proposed to use labels (using modules/paths),
jbonofre commented on PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#issuecomment-2251479293
It looks good to me. Thanks !
By the way, it would be also possible to update `.asf.yml` for "force" at
least one review. I proposed to use labels (using modules/paths), assign
nastra commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1691733551
##
site/docs/contribute.md:
##
@@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as
[Github pull requests]
* If a PR is related to an issue,
emkornfield commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1691057611
##
site/docs/contribute.md:
##
@@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as
[Github pull requests]
* If a PR is related to an is
Fokko commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1691042870
##
site/docs/contribute.md:
##
@@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as
[Github pull requests]
* If a PR is related to an issue, a
emkornfield commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1691018532
##
site/docs/contribute.md:
##
@@ -207,8 +218,8 @@ public class SnapshotManager implements ManageSnapshots {
// existing code...
@Override
- public Manag
emkornfield commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1691014322
##
site/docs/contribute.md:
##
@@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as
[Github pull requests]
* If a PR is related to an is
emkornfield commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1691012917
##
site/docs/contribute.md:
##
@@ -207,8 +218,8 @@ public class SnapshotManager implements ManageSnapshots {
// existing code...
@Override
- public Manag
Fokko commented on code in PR #10780:
URL: https://github.com/apache/iceberg/pull/10780#discussion_r1690996188
##
site/docs/contribute.md:
##
@@ -45,6 +45,17 @@ The Iceberg community prefers to receive contributions as
[Github pull requests]
* If a PR is related to an issue, a
emkornfield opened a new pull request, #10780:
URL: https://github.com/apache/iceberg/pull/10780
Based on mailing list discussion add focused language to contributing.md on
committing PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
10 matches
Mail list logo
