Re: [PR] Core:support redis and http lock-manager [iceberg]

BsoBird commented on code in PR #10688: URL: https://github.com/apache/iceberg/pull/10688#discussion_r1676751334 ## build.gradle: ## @@ -358,6 +358,7 @@ project(':iceberg-core') { implementation libs.jackson.databind implementation libs.caffeine implementation lib

Re: [PR] Core:support redis and http lock-manager [iceberg]

BsoBird commented on PR #10688: URL: https://github.com/apache/iceberg/pull/10688#issuecomment-2226738178 @danielcweeks @rdblue I know what you mean, Sir. 1.About abandoning the catalog implementation that relies on lockManager. I think this is too radical. I agree that it would b

Re: [PR] Core:support redis and http lock-manager [iceberg]

BsoBird commented on code in PR #10688: URL: https://github.com/apache/iceberg/pull/10688#discussion_r1676690715 ## build.gradle: ## @@ -358,6 +358,7 @@ project(':iceberg-core') { implementation libs.jackson.databind implementation libs.caffeine implementation lib

Re: [PR] Core:support redis and http lock-manager [iceberg]

danielcweeks commented on PR #10688: URL: https://github.com/apache/iceberg/pull/10688#issuecomment-2226150038 I don't think we should be adding new `LockManager` implementations. The general discussion has been that we want to deprecate catalog implementations that rely on external lockin

Re: [PR] Core:support redis and http lock-manager [iceberg]

rdblue commented on code in PR #10688: URL: https://github.com/apache/iceberg/pull/10688#discussion_r1676303612 ## build.gradle: ## @@ -358,6 +358,7 @@ project(':iceberg-core') { implementation libs.jackson.databind implementation libs.caffeine implementation libs

Re: [PR] Core:support redis and http lock-manager [iceberg]

BsoBird commented on code in PR #10688: URL: https://github.com/apache/iceberg/pull/10688#discussion_r1675655377 ## core/src/main/java/org/apache/iceberg/lock/ServerSideHttpLockManager.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Core:support redis and http lock-manager [iceberg]

BsoBird commented on code in PR #10688: URL: https://github.com/apache/iceberg/pull/10688#discussion_r1675648520 ## core/src/test/java/org/apache/iceberg/lock/TestHttpServer.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] Core:support redis and http lock-manager [iceberg]

BsoBird commented on code in PR #10688: URL: https://github.com/apache/iceberg/pull/10688#discussion_r1675609730 ## core/src/main/java/org/apache/iceberg/lock/RedissonLockManager.java: ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Core:support redis and http lock-manager [iceberg]

BsoBird commented on PR #10688: URL: https://github.com/apache/iceberg/pull/10688#issuecomment-2225235649 tips: According to the original plan, I originally intended to extend a zookeeper-based lockManager. However, I found that the whole iceberg project's dependency on zookeeper is quit

Re: [PR] Core:support redis and http lock-manager [iceberg]

BsoBird commented on code in PR #10688: URL: https://github.com/apache/iceberg/pull/10688#discussion_r1675609730 ## core/src/main/java/org/apache/iceberg/lock/RedissonLockManager.java: ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Core:support redis and http lock-manager [iceberg]

BsoBird commented on code in PR #10688: URL: https://github.com/apache/iceberg/pull/10688#discussion_r1675609730 ## core/src/main/java/org/apache/iceberg/lock/RedissonLockManager.java: ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Core:support redis and http lock-manager [iceberg]

BsoBird commented on code in PR #10688: URL: https://github.com/apache/iceberg/pull/10688#discussion_r1675607925 ## core/src/main/java/org/apache/iceberg/lock/ServerSideHttpLockManager.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Core:support redis and http lock-manager [iceberg]

BsoBird commented on code in PR #10688: URL: https://github.com/apache/iceberg/pull/10688#discussion_r1675602524 ## core/src/test/java/org/apache/iceberg/lock/RedisLockManagerTest.java: ## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] Core:support redis and http lock-manager [iceberg]

BsoBird commented on code in PR #10688: URL: https://github.com/apache/iceberg/pull/10688#discussion_r1675598848 ## core/src/test/java/org/apache/iceberg/lock/HttpLockManagerTest.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Core:support redis and http lock-manager [iceberg]

BsoBird commented on code in PR #10688: URL: https://github.com/apache/iceberg/pull/10688#discussion_r1675598848 ## core/src/test/java/org/apache/iceberg/lock/HttpLockManagerTest.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or