rdblue commented on code in PR #10688:
URL: https://github.com/apache/iceberg/pull/10688#discussion_r1676303612
##########
build.gradle:
##########
@@ -358,6 +358,7 @@ project(':iceberg-core') {
implementation libs.jackson.databind
implementation libs.caffeine
implementation libs.roaringbitmap
+ implementation libs.redission
Review Comment:
I don't think that we should move forward with a PR that adds Redis to the
classpath. This changes the classpath that will be included in the runtime
bundles, so at a minimum, we need to either make it optional or update all of
the LICENSE and NOTICE files to note the inclusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
