Re: [PR] Core: Use 'delete' if OverwriteFiles only deletes data files [iceberg]

nastra commented on code in PR #10150: URL: https://github.com/apache/iceberg/pull/10150#discussion_r1579059939 ## core/src/test/java/org/apache/iceberg/TestOverwrite.java: ## @@ -295,5 +343,6 @@ public void testValidatedOverwriteWithAppendSuccess() { .hasMessageStartin

Re: [PR] Core: Use 'delete' if OverwriteFiles only deletes data files [iceberg]

nastra commented on code in PR #10150: URL: https://github.com/apache/iceberg/pull/10150#discussion_r1579060905 ## core/src/test/java/org/apache/iceberg/TestOverwrite.java: ## @@ -135,6 +135,49 @@ public void createTestTable() throws IOException { commit(table, table.newAp

Re: [PR] Core: Use 'delete' if OverwriteFiles only deletes data files [iceberg]

amogh-jahagirdar commented on code in PR #10150: URL: https://github.com/apache/iceberg/pull/10150#discussion_r1578433465 ## core/src/test/java/org/apache/iceberg/TestOverwrite.java: ## @@ -295,5 +343,6 @@ public void testValidatedOverwriteWithAppendSuccess() { .hasMess

Re: [PR] Core: Use 'delete' if OverwriteFiles only deletes data files [iceberg]

nastra commented on code in PR #10150: URL: https://github.com/apache/iceberg/pull/10150#discussion_r1575736834 ## core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java: ## @@ -48,6 +48,10 @@ protected OverwriteFiles self() { @Override protected String operation(

Re: [PR] Core: Use 'delete' if OverwriteFiles only deletes data files [iceberg]

nastra commented on code in PR #10150: URL: https://github.com/apache/iceberg/pull/10150#discussion_r1575735207 ## core/src/test/java/org/apache/iceberg/TestOverwrite.java: ## @@ -101,8 +101,8 @@ public class TestOverwrite extends TestBase { ImmutableMap.of(1,

Re: [PR] Core: Use 'delete' if OverwriteFiles only deletes data files [iceberg]

amogh-jahagirdar commented on code in PR #10150: URL: https://github.com/apache/iceberg/pull/10150#discussion_r1572688551 ## core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java: ## @@ -48,6 +48,10 @@ protected OverwriteFiles self() { @Override protected String