nastra commented on code in PR #10150: URL: https://github.com/apache/iceberg/pull/10150#discussion_r1579059939
########## core/src/test/java/org/apache/iceberg/TestOverwrite.java: ########## @@ -295,5 +343,6 @@ public void testValidatedOverwriteWithAppendSuccess() { .hasMessageStartingWith("Cannot append file with rows that do not match filter"); assertThat(latestSnapshot(base, branch).snapshotId()).isEqualTo(baseId); + assertThat(latestSnapshot(table, branch).operation()).isEqualTo(DataOperations.APPEND); Review Comment: you're right, it's a bit confusing and probably better to leave this assertion out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org