Re: [PR] Core: Support view metadata compression [iceberg]

2023-10-11 Thread via GitHub
rdblue commented on PR #8552: URL: https://github.com/apache/iceberg/pull/8552#issuecomment-1758159463 Thanks, @nastra! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Core: Support view metadata compression [iceberg]

2023-10-11 Thread via GitHub
rdblue merged PR #8552: URL: https://github.com/apache/iceberg/pull/8552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Core: Support view metadata compression [iceberg]

2023-10-04 Thread via GitHub
nastra commented on code in PR #8552: URL: https://github.com/apache/iceberg/pull/8552#discussion_r1345331616 ## core/src/test/java/org/apache/iceberg/view/TestViewMetadataParser.java: ## @@ -308,4 +322,57 @@ public void replaceViewMetadataWithMultipleSQLsForDialect() throws Ex

Re: [PR] Core: Support view metadata compression [iceberg]

2023-10-02 Thread via GitHub
rdblue commented on code in PR #8552: URL: https://github.com/apache/iceberg/pull/8552#discussion_r1343150026 ## core/src/test/java/org/apache/iceberg/view/TestViewMetadataParser.java: ## @@ -308,4 +322,57 @@ public void replaceViewMetadataWithMultipleSQLsForDialect() throws Ex

Re: [PR] Core: Support view metadata compression [iceberg]

2023-10-02 Thread via GitHub
rdblue commented on code in PR #8552: URL: https://github.com/apache/iceberg/pull/8552#discussion_r1343147048 ## core/src/test/java/org/apache/iceberg/view/TestViewMetadataParser.java: ## @@ -18,18 +18,30 @@ */ package org.apache.iceberg.view; +import static org.apache.iceb