nastra commented on code in PR #8552:
URL: https://github.com/apache/iceberg/pull/8552#discussion_r1345331616
##########
core/src/test/java/org/apache/iceberg/view/TestViewMetadataParser.java:
##########
@@ -308,4 +322,57 @@ public void
replaceViewMetadataWithMultipleSQLsForDialect() throws Exception {
assertThat(replaced.currentVersion()).isEqualTo(viewVersion);
}
+
+ @ParameterizedTest
+ @ValueSource(strings = {"none", "gzip"})
+ public void metadataCompression(String codecName) throws IOException {
+ Codec codec = Codec.fromName(codecName);
+ String location = Paths.get(tmp.toString(), "v1" +
getFileExtension(codec)).toString();
Review Comment:
I was aligning this test with how compression was tested for table metadata
in
https://github.com/apache/iceberg/blob/c07f2aabc0a1d02f068ecf1514d2479c0fbdd3b0/core/src/test/java/org/apache/iceberg/TableMetadataParserTest.java#L63
but I've changed it to have explicit file names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
