Re: [PR] Core: Support removing keys from EnvironmentContext [iceberg]

2025-01-31 Thread via GitHub
rshkv commented on PR #12103: URL: https://github.com/apache/iceberg/pull/12103#issuecomment-2626779149 Thank you @nastra -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Core: Support removing keys from EnvironmentContext [iceberg]

2025-01-30 Thread via GitHub
nastra merged PR #12103: URL: https://github.com/apache/iceberg/pull/12103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Core: Support removing keys from EnvironmentContext [iceberg]

2025-01-29 Thread via GitHub
nastra commented on code in PR #12103: URL: https://github.com/apache/iceberg/pull/12103#discussion_r1933780261 ## core/src/test/java/org/apache/iceberg/TestEnvironmentContext.java: ## @@ -19,6 +19,7 @@ package org.apache.iceberg; import static org.assertj.core.api.Assertion

Re: [PR] Core: Support removing keys from EnvironmentContext [iceberg]

2025-01-28 Thread via GitHub
rshkv commented on code in PR #12103: URL: https://github.com/apache/iceberg/pull/12103#discussion_r1932589317 ## core/src/main/java/org/apache/iceberg/EnvironmentContext.java: ## @@ -52,4 +52,13 @@ public static Map get() { public static void put(String key, String value) {

Re: [PR] Core: Support removing keys from EnvironmentContext [iceberg]

2025-01-28 Thread via GitHub
nastra commented on code in PR #12103: URL: https://github.com/apache/iceberg/pull/12103#discussion_r1932394322 ## core/src/main/java/org/apache/iceberg/EnvironmentContext.java: ## @@ -52,4 +52,13 @@ public static Map get() { public static void put(String key, String value) {

[PR] Core: Support removing keys from EnvironmentContext [iceberg]

2025-01-25 Thread via GitHub
rshkv opened a new pull request, #12103: URL: https://github.com/apache/iceberg/pull/12103 Tiny change to support removing keys from `EnvironmentContext`. Useful when a JVM is shared by multiple jobs and jobs want to express different environment properties. -- This is an automated