nastra commented on code in PR #12103:
URL: https://github.com/apache/iceberg/pull/12103#discussion_r1932394322
##########
core/src/main/java/org/apache/iceberg/EnvironmentContext.java:
##########
@@ -52,4 +52,13 @@ public static Map<String, String> get() {
public static void put(String key, String value) {
PROPERTIES.put(key, value);
}
+
+ /**
+ * Remove the key from the global properties map.
+ *
+ * @param key The key whose value to remove
+ */
+ public static void remove(String key) {
Review Comment:
maybe the return type should be `String` here and the method would `return
PROPERTIES.remove(key)`. That way the test wouldn't need to check
`assertThatNoException().isThrownBy(() ->
EnvironmentContext.remove("test-key"));` but rather would make sure that the
method returned the value on the first remove and null on the second remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
