github-actions[bot] closed pull request #12555: Core: Simplify AuthManager API
URL: https://github.com/apache/iceberg/pull/12555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
github-actions[bot] commented on PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#issuecomment-2870385672
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If
github-actions[bot] commented on PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#issuecomment-2849609594
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
adutra commented on PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#issuecomment-2776589608
Sounds good, let's revisit later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
danielcweeks commented on PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#issuecomment-2776494155
I'm more than a little hesitant to start changing this now. Pivoting the
way we think about sessions/scopes doesn't really add a lot at this point and
we've just completed a major
adutra commented on PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#issuecomment-2761667634
@nastra is there any pending issues in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
nastra commented on code in PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#discussion_r2013839105
##
core/src/main/java/org/apache/iceberg/rest/auth/AuthManager.java:
##
@@ -33,77 +33,65 @@
public interface AuthManager extends AutoCloseable {
/**
- * Return
nastra commented on code in PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#discussion_r2013814366
##
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Manager.java:
##
@@ -64,18 +65,89 @@ public class OAuth2Manager extends RefreshingAuthManager {
private Aut
adutra commented on code in PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#discussion_r2013717006
##
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Manager.java:
##
@@ -64,18 +65,89 @@ public class OAuth2Manager extends RefreshingAuthManager {
private Aut
adutra commented on code in PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#discussion_r2013729592
##
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Manager.java:
##
@@ -64,18 +65,89 @@ public class OAuth2Manager extends RefreshingAuthManager {
private Aut
nastra commented on code in PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#discussion_r2013488629
##
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Manager.java:
##
@@ -64,18 +65,89 @@ public class OAuth2Manager extends RefreshingAuthManager {
private Aut
adutra commented on code in PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#discussion_r2012866102
##
core/src/main/java/org/apache/iceberg/rest/auth/AuthScopes.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
adutra commented on code in PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#discussion_r2012849829
##
core/src/test/java/org/apache/iceberg/rest/auth/TestBasicAuthManager.java:
##
@@ -30,7 +30,7 @@ class TestBasicAuthManager {
@Test
void missingUsername() {
adutra commented on code in PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#discussion_r2012845154
##
core/src/main/java/org/apache/iceberg/rest/auth/AuthManager.java:
##
@@ -33,74 +33,62 @@
public interface AuthManager extends AutoCloseable {
/**
- * Return
nastra commented on code in PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#discussion_r2011767343
##
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Manager.java:
##
@@ -64,18 +65,89 @@ public class OAuth2Manager extends RefreshingAuthManager {
private Aut
nastra commented on code in PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#discussion_r2011779235
##
core/src/test/java/org/apache/iceberg/rest/auth/TestOAuth2Manager.java:
##
@@ -130,24 +136,26 @@ void catalogSessionNoOAuth2Properties() {
@Test
void catalogS
nastra commented on code in PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#discussion_r2011765050
##
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Manager.java:
##
@@ -64,18 +65,89 @@ public class OAuth2Manager extends RefreshingAuthManager {
private Aut
nastra commented on code in PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#discussion_r2011765716
##
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Manager.java:
##
@@ -64,18 +65,89 @@ public class OAuth2Manager extends RefreshingAuthManager {
private Aut
nastra commented on code in PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#discussion_r2011744113
##
core/src/main/java/org/apache/iceberg/rest/auth/AuthScopes.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
nastra commented on code in PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#discussion_r2011733123
##
aws/src/main/java/org/apache/iceberg/aws/RESTSigV4AuthManager.java:
##
@@ -36,22 +38,58 @@
@SuppressWarnings("unused") // loaded by reflection
public class RESTSi
nastra commented on code in PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#discussion_r2011714336
##
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Manager.java:
##
@@ -64,18 +65,89 @@ public class OAuth2Manager extends RefreshingAuthManager {
private Aut
nastra commented on code in PR #12555:
URL: https://github.com/apache/iceberg/pull/12555#discussion_r2011706431
##
core/src/main/java/org/apache/iceberg/rest/auth/AuthManager.java:
##
@@ -33,74 +33,62 @@
public interface AuthManager extends AutoCloseable {
/**
- * Return
22 matches
Mail list logo
