Re: [PR] Core: Reword exception message in RewriteManifests [iceberg]

2024-06-06 Thread via GitHub
amogh-jahagirdar commented on PR #10446: URL: https://github.com/apache/iceberg/pull/10446#issuecomment-2153645114 Sorry, and thanks @anuragmantri for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Core: Reword exception message in RewriteManifests [iceberg]

2024-06-06 Thread via GitHub
amogh-jahagirdar merged PR #10446: URL: https://github.com/apache/iceberg/pull/10446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Core: Reword exception message in RewriteManifests [iceberg]

2024-06-06 Thread via GitHub
amogh-jahagirdar commented on PR #10446: URL: https://github.com/apache/iceberg/pull/10446#issuecomment-2153644655 Thanks @ajantha-bhat ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Core: Reword exception message in RewriteManifests [iceberg]

2024-06-06 Thread via GitHub
ajantha-bhat commented on code in PR #10446: URL: https://github.com/apache/iceberg/pull/10446#discussion_r1629502264 ## core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java: ## @@ -275,14 +275,17 @@ private boolean matchesPredicate(ManifestFile manifest) { retur

Re: [PR] Core: Reword exception message in RewriteManifests [iceberg]

2024-06-05 Thread via GitHub
amogh-jahagirdar commented on code in PR #10446: URL: https://github.com/apache/iceberg/pull/10446#discussion_r1628610685 ## core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java: ## @@ -275,14 +275,17 @@ private boolean matchesPredicate(ManifestFile manifest) { r