amogh-jahagirdar commented on code in PR #10446:
URL: https://github.com/apache/iceberg/pull/10446#discussion_r1628610685
##########
core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java:
##########
@@ -275,14 +275,17 @@ private boolean matchesPredicate(ManifestFile manifest) {
return predicate == null || predicate.test(manifest);
}
- private void validateDeletedManifests(Set<ManifestFile> currentManifests) {
+ private void validateDeletedManifests(
+ Set<ManifestFile> currentManifests, long currentSnapshotID) {
// directly deleted manifests must be still present in the current snapshot
deletedManifests.stream()
.filter(manifest -> !currentManifests.contains(manifest))
.findAny()
.ifPresent(
manifest -> {
- throw new ValidationException("Manifest is missing: %s",
manifest.path());
+ throw new ValidationException(
+ "Deleted manifest %s could not be found in the current
snapshot %d",
Review Comment:
Nit: Could we just say "Deleted manifest %s could not be found in snapshot
%d". Sorry I think I said "current" in Slack, but I actually think it may
confuse users because by the time it surfaces the "current" can be different
than what's in the message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
