Re: [PR] Core: Reset to main as part of replace shouldn't remove main ref [iceberg]

2025-01-26 Thread via GitHub
github-actions[bot] commented on PR #11819: URL: https://github.com/apache/iceberg/pull/11819#issuecomment-2614650126 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Core: Reset to main as part of replace shouldn't remove main ref [iceberg]

2025-01-26 Thread via GitHub
github-actions[bot] closed pull request #11819: Core: Reset to main as part of replace shouldn't remove main ref URL: https://github.com/apache/iceberg/pull/11819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Core: Reset to main as part of replace shouldn't remove main ref [iceberg]

2024-12-18 Thread via GitHub
amogh-jahagirdar commented on PR #11819: URL: https://github.com/apache/iceberg/pull/11819#issuecomment-2552745314 >This PR resolves https://github.com/apache/iceberg/issues/11777, right? https://github.com/apache/iceberg/pull/11779 is my another PR with a different approach. Yeah so

Re: [PR] Core: Reset to main as part of replace shouldn't remove main ref [iceberg]

2024-12-18 Thread via GitHub
ebyhr commented on PR #11819: URL: https://github.com/apache/iceberg/pull/11819#issuecomment-2552738351 This PR resolves #11777, right? https://github.com/apache/iceberg/pull/11779 is my another PR with a different approach. -- This is an automated message from the Apache Git Service

Re: [PR] Core: Reset to main as part of replace shouldn't remove main ref [iceberg]

2024-12-18 Thread via GitHub
amogh-jahagirdar commented on code in PR #11819: URL: https://github.com/apache/iceberg/pull/11819#discussion_r1891027757 ## core/src/main/java/org/apache/iceberg/MetadataUpdate.java: ## @@ -338,7 +338,11 @@ public String name() { @Override public void applyTo(TableM

Re: [PR] Core: Reset to main as part of replace shouldn't remove main ref [iceberg]

2024-12-18 Thread via GitHub
amogh-jahagirdar commented on code in PR #11819: URL: https://github.com/apache/iceberg/pull/11819#discussion_r1891022575 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -1299,11 +1299,7 @@ public Builder removeRef(String name) { private Builder resetMa