amogh-jahagirdar commented on PR #11819: URL: https://github.com/apache/iceberg/pull/11819#issuecomment-2552745314
>This PR resolves https://github.com/apache/iceberg/issues/11777, right? https://github.com/apache/iceberg/pull/11779 is my another PR with a different approach. Yeah sorry it's a way to solve #11777, sorry I didn't quite mark it yet with "fixes" as I'm still mulling through the tradeoffs and wanted to see if CI broke with this change. @ebyhr what do you think? I was largely trying to think of simple ways to avoid a protocol change , and making the "RemoveRef(Main)" update not clear the snapshot history seemed to be the best way. There's the TableMetadata.removeRef API which will just clear the snapshot log , and we may just want to either change the behavior of that/add a separate removeRefAndHistory API for people who want that ability -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
