Re: [PR] Core: Remove one comment from FastAppend [iceberg]

gaborkaszab commented on PR #10995: URL: https://github.com/apache/iceberg/pull/10995#issuecomment-2441035715 Thanks for taking a look, @nastra ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Core: Remove one comment from FastAppend [iceberg]

nastra merged PR #10995: URL: https://github.com/apache/iceberg/pull/10995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Core: Remove one comment from FastAppend [iceberg]

gaborkaszab commented on code in PR #10995: URL: https://github.com/apache/iceberg/pull/10995#discussion_r1816970746 ## core/src/test/java/org/apache/iceberg/TestFastAppend.java: ## @@ -252,11 +252,36 @@ public void testFailure() { assertThat(new File(newManifest.path())).d

Re: [PR] Core: Remove one comment from FastAppend [iceberg]

nastra commented on code in PR #10995: URL: https://github.com/apache/iceberg/pull/10995#discussion_r1815163457 ## core/src/test/java/org/apache/iceberg/TestFastAppend.java: ## @@ -252,11 +252,36 @@ public void testFailure() { assertThat(new File(newManifest.path())).doesNo

Re: [PR] Core: Remove one comment from FastAppend [iceberg]

gaborkaszab commented on PR #10995: URL: https://github.com/apache/iceberg/pull/10995#issuecomment-2435425999 Hi @nastra , Do you disagree with my reasoning? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Core: Remove one comment from FastAppend [iceberg]

gaborkaszab commented on code in PR #10995: URL: https://github.com/apache/iceberg/pull/10995#discussion_r1768454689 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -24,20 +24,14 @@ import java.util.Set; import org.apache.iceberg.encryption.EncryptedOutputFile;

Re: [PR] Core: Remove one comment from FastAppend [iceberg]

gaborkaszab commented on code in PR #10995: URL: https://github.com/apache/iceberg/pull/10995#discussion_r1768445973 ## core/src/test/java/org/apache/iceberg/TestFastAppend.java: ## @@ -252,11 +252,36 @@ public void testFailure() { assertThat(new File(newManifest.path())).d

Re: [PR] Core: Remove one comment from FastAppend [iceberg]

gaborkaszab commented on code in PR #10995: URL: https://github.com/apache/iceberg/pull/10995#discussion_r1768445973 ## core/src/test/java/org/apache/iceberg/TestFastAppend.java: ## @@ -252,11 +252,36 @@ public void testFailure() { assertThat(new File(newManifest.path())).d

Re: [PR] Core: Remove one comment from FastAppend [iceberg]

nastra commented on code in PR #10995: URL: https://github.com/apache/iceberg/pull/10995#discussion_r1754002089 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -24,20 +24,14 @@ import java.util.Set; import org.apache.iceberg.encryption.EncryptedOutputFile; imp

Re: [PR] Core: Remove one comment from FastAppend [iceberg]

nastra commented on code in PR #10995: URL: https://github.com/apache/iceberg/pull/10995#discussion_r1753988942 ## core/src/test/java/org/apache/iceberg/TestFastAppend.java: ## @@ -252,11 +252,36 @@ public void testFailure() { assertThat(new File(newManifest.path())).doesNo

[PR] Core: Remove one comment from FastAppend [iceberg]

gaborkaszab opened a new pull request, #10995: URL: https://github.com/apache/iceberg/pull/10995 There is a comment for FastAppend that mentions the number of commit retries done by the class. I removed it for 2 reasons: 1) Not the FastAppend class does the commit so the commit retries