nastra commented on code in PR #10995:
URL: https://github.com/apache/iceberg/pull/10995#discussion_r1754002089
##########
core/src/main/java/org/apache/iceberg/FastAppend.java:
##########
@@ -24,20 +24,14 @@
import java.util.Set;
import org.apache.iceberg.encryption.EncryptedOutputFile;
import org.apache.iceberg.events.CreateSnapshotEvent;
-import org.apache.iceberg.exceptions.CommitFailedException;
import org.apache.iceberg.exceptions.RuntimeIOException;
import org.apache.iceberg.io.InputFile;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.relocated.com.google.common.collect.Iterables;
import org.apache.iceberg.relocated.com.google.common.collect.Lists;
import org.apache.iceberg.util.CharSequenceSet;
-/**
- * {@link AppendFiles Append} implementation that adds a new manifest file for
the write.
- *
- * <p>This implementation will attempt to commit 5 times before throwing {@link
Review Comment:
why not rather update the comment and refer to the table property that is
being used for retries: `TableProperties#COMMIT_NUM_RETRIES_DEFAULT`?
In your PR description you mention that retries aren't done for
`FastAppend`, but retries are done for all subclasses of `SnapshotProducer`.
Also if we update this javadoc, then we should align this for other
subclasses of `SnapshotProducer` as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
