Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

amogh-jahagirdar merged PR #9298: URL: https://github.com/apache/iceberg/pull/9298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat commented on PR #9298: URL: https://github.com/apache/iceberg/pull/9298#issuecomment-1887057080 ping. Anything else needed for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat commented on PR #9298: URL: https://github.com/apache/iceberg/pull/9298#issuecomment-1882157466 PR is ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1444122327 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifier to

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

manuzhang commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1444117653 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifier toV1T

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

manuzhang commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1444116391 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -38,8 +38,7 @@ * the metadata table using a {@link StaticTableOperations}. This way no Catal

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

manuzhang commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1444116391 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -38,8 +38,7 @@ * the metadata table using a {@link StaticTableOperations}. This way no Catal

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat commented on PR #9298: URL: https://github.com/apache/iceberg/pull/9298#issuecomment-1880052870 Retriggering the build due to flaky test in Flink. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat closed pull request #9298: Core: Remove deprecated method from BaseMetadataTable URL: https://github.com/apache/iceberg/pull/9298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1443997108 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifier to

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

nastra commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1443801136 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifier toV1Tabl

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1442638780 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/BaseFileRewriteCoordinator.java: ## @@ -72,18 +70,12 @@ public void clearRewrite(Table table, String fil

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1442241575 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/BaseFileRewriteCoordinator.java: ## @@ -72,18 +70,12 @@ public void clearRewrite(Table table, String

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1442246021 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1442241575 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/BaseFileRewriteCoordinator.java: ## @@ -72,18 +70,12 @@ public void clearRewrite(Table table, String

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

amogh-jahagirdar commented on PR #9298: URL: https://github.com/apache/iceberg/pull/9298#issuecomment-1876211849 Sorry for the delay in review on this @ajantha-bhat , I'll take a look at this tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat commented on PR #9298: URL: https://github.com/apache/iceberg/pull/9298#issuecomment-1870198207 Just rebased to resolve conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1431304330 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifier to

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1430095953 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifier to

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428998565 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428998565 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428998565 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428998565 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428998565 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428998565 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428998565 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428994320 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifier to

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428984670 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifier to

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428887738 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -99,17 +98,10 @@ static Map transformSpecs( abstract MetadataTableType metadataTabl

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428887230 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428887230 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428761407 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifier to

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428680842 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifier to

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428680776 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifier to

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428471085 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428076109 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifier to

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428074232 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifier to

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

nastra commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428012608 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifier toV1Tabl

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat commented on PR #9298: URL: https://github.com/apache/iceberg/pull/9298#issuecomment-1857854433 @nastra, @Fokko: PR is ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat commented on PR #9298: URL: https://github.com/apache/iceberg/pull/9298#issuecomment-1855949807 Looks like some tests are directly casting metadata tables with `HasTableOperations`. So, some more work is needed for this PR. Let me work on it and ping when it is ready. --

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1426742343 ## core/src/main/java/org/apache/iceberg/SerializableTable.java: ## @@ -105,6 +105,8 @@ private String metadataFileLocation(Table table) { if (table instanceo

[PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

ajantha-bhat opened a new pull request, #9298: URL: https://github.com/apache/iceberg/pull/9298 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,