amogh-jahagirdar commented on code in PR #9298:
URL: https://github.com/apache/iceberg/pull/9298#discussion_r1428471085


##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java:
##########
@@ -948,6 +950,17 @@ public static 
org.apache.spark.sql.catalyst.TableIdentifier toV1TableIdentifier(
     return org.apache.spark.sql.catalyst.TableIdentifier.apply(table, 
database);
   }
 
+  static String tableUUID(org.apache.iceberg.Table table) {
+    if (table instanceof HasTableOperations) {

Review Comment:
   Yeah the argument there is that the metadata table can be considered as a 
separate table and should therefore have it's own unique identifier compared to 
the base table. 
   
   But I think @nastra point still stands, even if it's different then the base 
table UUID, why does that matter here? I think we just want the table.uuid() 
right? or do we need the metadata table's underlying table's UUID?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to