Re: [PR] Core: Prevent duplicate data files [iceberg]

nastra commented on code in PR #10007: URL: https://github.com/apache/iceberg/pull/10007#discussion_r1533675374 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -83,9 +85,13 @@ protected Map summary() { @Override public FastAppend appendFile(DataFile file)

Re: [PR] Core: Prevent duplicate data files [iceberg]

nastra commented on code in PR #10007: URL: https://github.com/apache/iceberg/pull/10007#discussion_r1533635845 ## core/src/test/java/org/apache/iceberg/TestBaseIncrementalAppendScan.java: ## @@ -67,13 +67,13 @@ public void fromSnapshotInclusiveWithTag() { table.manageSnaps

Re: [PR] Core: Prevent duplicate data files [iceberg]

nastra commented on code in PR #10007: URL: https://github.com/apache/iceberg/pull/10007#discussion_r1533634773 ## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ## @@ -80,6 +80,8 @@ abstract class MergingSnapshotProducer extends SnapshotProducer { //

Re: [PR] Core: Prevent duplicate data files [iceberg]

nastra commented on code in PR #10007: URL: https://github.com/apache/iceberg/pull/10007#discussion_r1533633016 ## core/src/main/java/org/apache/iceberg/FastAppend.java: ## @@ -43,6 +44,7 @@ class FastAppend extends SnapshotProducer implements AppendFiles { private final Par