nastra commented on code in PR #10007:
URL: https://github.com/apache/iceberg/pull/10007#discussion_r1533634773
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -80,6 +80,8 @@ abstract class MergingSnapshotProducer<ThisT> extends
SnapshotProducer<ThisT> {
// update data
private final List<DataFile> newDataFiles = Lists.newArrayList();
+ private final CharSequenceSet newDataFilePaths = CharSequenceSet.empty();
+ private final CharSequenceSet newDeleteFilePaths = CharSequenceSet.empty();
Review Comment:
subclasses of `DataFile` / `DeleteFile` don't implement `equals()` /
`hashCode()`, so using a separate set to store the file path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
