Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-02-11 Thread via GitHub
ebyhr commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1951940306 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return (Li

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-02-11 Thread via GitHub
jacobmarble commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1951255807 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: retu

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-02-11 Thread via GitHub
jacobmarble commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1951259929 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: retu

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-02-11 Thread via GitHub
jacobmarble commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1951255807 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: retu

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-02-11 Thread via GitHub
Fokko commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1951168267 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return (Li

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-01-14 Thread via GitHub
ebyhr commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1915834371 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return (Li

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2024-12-19 Thread via GitHub
ebyhr commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1891598000 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return (Li

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2024-12-19 Thread via GitHub
Fokko commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1891398081 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return (Li

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2024-12-17 Thread via GitHub
Fokko commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1888170004 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return (Li

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2024-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1887748229 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP:

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2024-12-16 Thread via GitHub
ebyhr commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1887709351 ## api/src/test/java/org/apache/iceberg/types/TestConversions.java: ## @@ -111,9 +111,9 @@ public void testByteBufferConversions() { assertConversion( 400

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2024-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1887202656 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP:

[PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2024-12-12 Thread via GitHub
ebyhr opened a new pull request, #11775: URL: https://github.com/apache/iceberg/pull/11775 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma