Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-05-27 Thread via GitHub
ajantha-bhat commented on PR #11775: URL: https://github.com/apache/iceberg/pull/11775#issuecomment-2914902672 We faced this at Dremio too : https://github.com/apache/iceberg/issues/13160 Looks forward to this fix. -- This is an automated message from the Apache Git Service. To res

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-05-06 Thread via GitHub
ebyhr commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r2074715304 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return (Li

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-05-06 Thread via GitHub
ebyhr commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r2074715304 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return (Li

[PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-05-06 Thread via GitHub
ebyhr opened a new pull request, #11775: URL: https://github.com/apache/iceberg/pull/11775 The previous logic leads to overflow when we pass timestamp nanos long value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-05-05 Thread via GitHub
ebyhr commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r2074715304 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return (Li

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-05-02 Thread via GitHub
github-actions[bot] closed pull request #11775: Core: Fix numeric overflow of timestamp nano literal URL: https://github.com/apache/iceberg/pull/11775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-05-02 Thread via GitHub
github-actions[bot] commented on PR #11775: URL: https://github.com/apache/iceberg/pull/11775#issuecomment-2848305835 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-04-25 Thread via GitHub
github-actions[bot] commented on PR #11775: URL: https://github.com/apache/iceberg/pull/11775#issuecomment-2831648013 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-03-26 Thread via GitHub
Fokko commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r2014744159 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return (Li

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-03-14 Thread via GitHub
ebyhr commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1996456626 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return (Li

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-03-14 Thread via GitHub
github-actions[bot] commented on PR #11775: URL: https://github.com/apache/iceberg/pull/11775#issuecomment-2726047205 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-02-11 Thread via GitHub
ebyhr commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1951940306 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return (Li

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-02-11 Thread via GitHub
jacobmarble commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1951255807 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: retu

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-02-11 Thread via GitHub
jacobmarble commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1951259929 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: retu

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-02-11 Thread via GitHub
jacobmarble commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1951255807 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: retu

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-02-11 Thread via GitHub
Fokko commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1951168267 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return (Li

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2025-01-14 Thread via GitHub
ebyhr commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1915834371 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return (Li

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2024-12-19 Thread via GitHub
ebyhr commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1891598000 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return (Li

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2024-12-19 Thread via GitHub
Fokko commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1891398081 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return (Li

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2024-12-17 Thread via GitHub
Fokko commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1888170004 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP: return (Li

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2024-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1887748229 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP:

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2024-12-16 Thread via GitHub
ebyhr commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1887709351 ## api/src/test/java/org/apache/iceberg/types/TestConversions.java: ## @@ -111,9 +111,9 @@ public void testByteBufferConversions() { assertConversion( 400

Re: [PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2024-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #11775: URL: https://github.com/apache/iceberg/pull/11775#discussion_r1887202656 ## api/src/main/java/org/apache/iceberg/expressions/Literals.java: ## @@ -300,8 +300,7 @@ public Literal to(Type type) { case TIMESTAMP:

[PR] Core: Fix numeric overflow of timestamp nano literal [iceberg]

2024-12-12 Thread via GitHub
ebyhr opened a new pull request, #11775: URL: https://github.com/apache/iceberg/pull/11775 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma