Re: [PR] Core: Fix null partitions in PartitionSet [iceberg]

2023-12-08 Thread via GitHub
aokolnychyi commented on PR #9248: URL: https://github.com/apache/iceberg/pull/9248#issuecomment-1847830279 Thanks, @RussellSpitzer! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Core: Fix null partitions in PartitionSet [iceberg]

2023-12-08 Thread via GitHub
aokolnychyi merged PR #9248: URL: https://github.com/apache/iceberg/pull/9248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Core: Fix null partitions in PartitionSet [iceberg]

2023-12-08 Thread via GitHub
aokolnychyi closed pull request #9248: Core: Fix null partitions in PartitionSet URL: https://github.com/apache/iceberg/pull/9248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Core: Fix null partitions in PartitionSet [iceberg]

2023-12-07 Thread via GitHub
aokolnychyi commented on code in PR #9248: URL: https://github.com/apache/iceberg/pull/9248#discussion_r1419859782 ## core/src/test/java/org/apache/iceberg/util/TestPartitionMap.java: ## @@ -274,9 +274,11 @@ public void testKeyAndEntrySetEquality() { map1.put(BY_DATA_SPEC

Re: [PR] Core: Fix null partitions in PartitionSet [iceberg]

2023-12-07 Thread via GitHub
aokolnychyi commented on code in PR #9248: URL: https://github.com/apache/iceberg/pull/9248#discussion_r1419859485 ## core/src/test/java/org/apache/iceberg/util/TestPartitionSet.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

[PR] Core: Fix null partitions in PartitionSet [iceberg]

2023-12-07 Thread via GitHub
aokolnychyi opened a new pull request, #9248: URL: https://github.com/apache/iceberg/pull/9248 This PR fixes usage of `null` partitions in `PartitionSet`. Previously, it was possible to store null partitions for unpartitioned specs but we could not retrieve them back. The set returned `fals