aokolnychyi commented on code in PR #9248:
URL: https://github.com/apache/iceberg/pull/9248#discussion_r1419859782
##########
core/src/test/java/org/apache/iceberg/util/TestPartitionMap.java:
##########
@@ -274,9 +274,11 @@ public void testKeyAndEntrySetEquality() {
map1.put(BY_DATA_SPEC.specId(), Row.of("aaa"), "v1");
map1.put(BY_DATA_SPEC.specId(), Row.of("bbb"), "v2");
+ map1.put(UNPARTITIONED_SPEC.specId(), null, "v3");
Review Comment:
Our `PartitionMap` uses `PartitionSet` for `keySet()`.
##########
core/src/test/java/org/apache/iceberg/util/TestPartitionMap.java:
##########
@@ -274,9 +274,11 @@ public void testKeyAndEntrySetEquality() {
map1.put(BY_DATA_SPEC.specId(), Row.of("aaa"), "v1");
map1.put(BY_DATA_SPEC.specId(), Row.of("bbb"), "v2");
+ map1.put(UNPARTITIONED_SPEC.specId(), null, "v3");
Review Comment:
Our `PartitionMap` uses `PartitionSet` for `keySet()`. This did not work
previously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
