Re: [PR] Core: Fix UnicodeUtil#truncateStringMax returns malformed string. [iceberg]

2024-09-22 Thread via GitHub
zhongyujiang commented on code in PR #11161: URL: https://github.com/apache/iceberg/pull/11161#discussion_r1770813666 ## core/src/test/java/org/apache/iceberg/TestMetricsTruncation.java: ## @@ -273,5 +282,23 @@ public void testTruncateStringMax() { .as( "Te

Re: [PR] Core: Fix UnicodeUtil#truncateStringMax returns malformed string. [iceberg]

2024-09-22 Thread via GitHub
nastra commented on code in PR #11161: URL: https://github.com/apache/iceberg/pull/11161#discussion_r1770808088 ## core/src/test/java/org/apache/iceberg/TestMetricsTruncation.java: ## @@ -273,5 +282,23 @@ public void testTruncateStringMax() { .as( "Test inp

Re: [PR] Core: Fix UnicodeUtil#truncateStringMax returns malformed string. [iceberg]

2024-09-22 Thread via GitHub
zhongyujiang commented on code in PR #11161: URL: https://github.com/apache/iceberg/pull/11161#discussion_r1770764300 ## core/src/test/java/org/apache/iceberg/TestMetricsTruncation.java: ## @@ -202,11 +202,20 @@ public void testTruncateStringMax() { String test5 = "\uDBFF\u

Re: [PR] Core: Fix UnicodeUtil#truncateStringMax returns malformed string. [iceberg]

2024-09-22 Thread via GitHub
zhongyujiang commented on code in PR #11161: URL: https://github.com/apache/iceberg/pull/11161#discussion_r1770763130 ## core/src/test/java/org/apache/iceberg/TestMetricsTruncation.java: ## @@ -274,4 +274,17 @@ public void testTruncateStringMax() { "Test input with

Re: [PR] Core: Fix UnicodeUtil#truncateStringMax returns malformed string. [iceberg]

2024-09-22 Thread via GitHub
zhongyujiang commented on code in PR #11161: URL: https://github.com/apache/iceberg/pull/11161#discussion_r1770762980 ## api/src/main/java/org/apache/iceberg/util/UnicodeUtil.java: ## @@ -93,4 +93,24 @@ public static Literal truncateStringMax(Literal inpu } return nul

Re: [PR] Core: Fix UnicodeUtil#truncateStringMax returns malformed string. [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #11161: URL: https://github.com/apache/iceberg/pull/11161#discussion_r1767608468 ## core/src/test/java/org/apache/iceberg/TestMetricsTruncation.java: ## @@ -274,4 +274,17 @@ public void testTruncateStringMax() { "Test input wit

Re: [PR] Core: Fix UnicodeUtil#truncateStringMax returns malformed string. [iceberg]

2024-09-19 Thread via GitHub
RussellSpitzer commented on code in PR #11161: URL: https://github.com/apache/iceberg/pull/11161#discussion_r1767604741 ## api/src/main/java/org/apache/iceberg/util/UnicodeUtil.java: ## @@ -93,4 +93,24 @@ public static Literal truncateStringMax(Literal inpu } return n

Re: [PR] Core: Fix UnicodeUtil#truncateStringMax returns malformed string. [iceberg]

2024-09-18 Thread via GitHub
zhongyujiang commented on PR #11161: URL: https://github.com/apache/iceberg/pull/11161#issuecomment-2359897318 @amogh-jahagirdar @nastra can you please help review this? thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] Core: Fix UnicodeUtil#truncateStringMax returns malformed string. [iceberg]

2024-09-18 Thread via GitHub
zhongyujiang opened a new pull request, #11161: URL: https://github.com/apache/iceberg/pull/11161 We encountered an exception while writing data, and the stack trace is as follows. It occurred during the collection of Parquet column metrics: Exception stack: ``` Suppressed: or