zhongyujiang commented on code in PR #11161:
URL: https://github.com/apache/iceberg/pull/11161#discussion_r1770763130
##########
core/src/test/java/org/apache/iceberg/TestMetricsTruncation.java:
##########
@@ -274,4 +274,17 @@ public void testTruncateStringMax() {
"Test input with multiple 4 byte UTF-8 character where the first
unicode character should be incremented")
.isEqualTo(0);
}
+
+ @Test
+ public void testTruncateStringMaxUpperBound() {
Review Comment:
Moved this to `testTruncateStringMax`
> The test cases for +1 and MAX_CODE_POINT are there already right?
Yes, there is already one test case for MAX_CODE_POINT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
