Re: [PR] Core: FileRewritePlanner implementation [iceberg]

stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2014688814 ## core/src/main/java/org/apache/iceberg/actions/RewriteFileGroupPlanner.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

pvary commented on PR #12493: URL: https://github.com/apache/iceberg/pull/12493#issuecomment-2763228406 Merged to main. Thanks for the review @stevenzwu and @RussellSpitzer! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

pvary merged PR #12493: URL: https://github.com/apache/iceberg/pull/12493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

RussellSpitzer commented on PR #12493: URL: https://github.com/apache/iceberg/pull/12493#issuecomment-2762698906 I haven't had time to check the rest of this, but I trust @stevenzwu 's review so please go on without me. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2017052085 ## core/src/main/java/org/apache/iceberg/actions/RewritePositionDeletesGroupPlanner.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2017027965 ## core/src/test/java/org/apache/iceberg/actions/TestBinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

pvary commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2016137775 ## core/src/test/java/org/apache/iceberg/actions/TestBinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

pvary commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2016143274 ## core/src/test/java/org/apache/iceberg/actions/TestBinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

pvary commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2016152148 ## core/src/test/java/org/apache/iceberg/actions/TestBinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

pvary commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2016083801 ## core/src/main/java/org/apache/iceberg/actions/SizeBasedDataRewriter.java: ## @@ -49,15 +56,15 @@ public abstract class SizeBasedDataRewriter extends SizeBasedFileRe

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

pvary commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2016142918 ## core/src/test/java/org/apache/iceberg/actions/TestBinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

pvary commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2016139881 ## core/src/test/java/org/apache/iceberg/actions/TestBinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

pvary commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2016136447 ## core/src/test/java/org/apache/iceberg/actions/TestBinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

pvary commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2016134878 ## core/src/main/java/org/apache/iceberg/actions/RewritePositionDeletesGroupPlanner.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

pvary commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2016087097 ## core/src/main/java/org/apache/iceberg/actions/BinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

pvary commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2016084243 ## core/src/main/java/org/apache/iceberg/actions/BinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

pvary commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2016081277 ## core/src/main/java/org/apache/iceberg/actions/RewriteFileGroupPlanner.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

pvary commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2016082527 ## core/src/main/java/org/apache/iceberg/actions/RewritePositionDeletesGroupPlanner.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015154046 ## core/src/test/java/org/apache/iceberg/actions/TestBinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2014782759 ## core/src/main/java/org/apache/iceberg/actions/RewritePositionDeletesGroupPlanner.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015157484 ## core/src/test/java/org/apache/iceberg/actions/TestBinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015139989 ## core/src/test/java/org/apache/iceberg/actions/TestBinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015155240 ## core/src/test/java/org/apache/iceberg/actions/TestBinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015152999 ## core/src/test/java/org/apache/iceberg/actions/TestBinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015149619 ## core/src/test/java/org/apache/iceberg/actions/TestBinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015142847 ## core/src/test/java/org/apache/iceberg/actions/TestBinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015125611 ## core/src/main/java/org/apache/iceberg/actions/RewritePositionDeletesGroupPlanner.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015095511 ## core/src/main/java/org/apache/iceberg/actions/BinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015078649 ## core/src/main/java/org/apache/iceberg/actions/BinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2015046752 ## core/src/main/java/org/apache/iceberg/actions/BinPackRewriteFileGroupPlanner.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

RussellSpitzer commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2014994662 ## core/src/main/java/org/apache/iceberg/actions/SizeBasedDataRewriter.java: ## @@ -49,15 +56,15 @@ public abstract class SizeBasedDataRewriter extends SizeBa

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

stevenzwu commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2014975086 ## core/src/main/java/org/apache/iceberg/actions/SizeBasedFileRewritePlanner.java: ## @@ -0,0 +1,361 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

pvary commented on PR #12493: URL: https://github.com/apache/iceberg/pull/12493#issuecomment-2753796490 Thanks @RussellSpitzer for the review! I have tried to answer and address your questions! -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

pvary commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2013719350 ## core/src/main/java/org/apache/iceberg/actions/RewriteFileGroupPlanner.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

pvary commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2013727684 ## core/src/main/java/org/apache/iceberg/actions/RewriteFileGroupPlanner.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

pvary commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2013698861 ## core/src/main/java/org/apache/iceberg/actions/RewriteFileGroupPlanner.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

pvary commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2013692297 ## core/src/main/java/org/apache/iceberg/actions/RewritePositionDeletesGroup.java: ## @@ -50,16 +53,16 @@ public RewritePositionDeletesGroup( FileGroupInfo info,

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

pvary commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2013691646 ## core/src/main/java/org/apache/iceberg/actions/RewriteFileGroup.java: ## @@ -48,14 +51,14 @@ public RewriteFileGroup( List fileScanTasks, int outputSpec

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

RussellSpitzer commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2012934021 ## core/src/main/java/org/apache/iceberg/actions/RewriteFileGroupPlanner.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

RussellSpitzer commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2012966051 ## core/src/main/java/org/apache/iceberg/actions/RewritePositionDeletesGroup.java: ## @@ -50,16 +53,16 @@ public RewritePositionDeletesGroup( FileGroupI

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

RussellSpitzer commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2012931655 ## core/src/main/java/org/apache/iceberg/actions/RewriteFileGroupPlanner.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

RussellSpitzer commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2012945454 ## core/src/main/java/org/apache/iceberg/actions/RewriteFileGroupPlanner.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

RussellSpitzer commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2012937314 ## core/src/main/java/org/apache/iceberg/actions/RewriteFileGroupPlanner.java: ## @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Core: FileRewritePlanner implementation [iceberg]

RussellSpitzer commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2012929572 ## core/src/main/java/org/apache/iceberg/actions/RewriteFileGroup.java: ## @@ -48,14 +51,14 @@ public RewriteFileGroup( List fileScanTasks, int o

[PR] Core: FileRewritePlanner implementation [iceberg]

pvary opened a new pull request, #12493: URL: https://github.com/apache/iceberg/pull/12493 This PR creates the core implementations for the Planners defined by #12306. The PR deprecates the old `*Rewriter` implementations. Adds test for the Planners. This is part of the #11513