pvary commented on code in PR #12493: URL: https://github.com/apache/iceberg/pull/12493#discussion_r2013692297
########## core/src/main/java/org/apache/iceberg/actions/RewritePositionDeletesGroup.java: ########## @@ -50,16 +53,16 @@ public RewritePositionDeletesGroup( FileGroupInfo info, List<PositionDeletesScanTask> tasks, long writeMaxFileSize, - long splitSize, + long inputSplitSize, Review Comment: I have forgot to rename these in my previous PR. During the review we changed from splitSize to inputSplitSize to highlight that this is for the input. We did the rename in the parent class (RewriteGroupBase), but I didn't do it here. Since this is a new class introduced by my previous PR, I felt that we should keep the naming consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org