Re: [PR] Core: Change Delete granularity to file for new tables [iceberg]

2024-12-12 Thread via GitHub
amogh-jahagirdar commented on code in PR #11478: URL: https://github.com/apache/iceberg/pull/11478#discussion_r1882456464 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMerge.java: ## @@ -231,7 +233,6 @@ public void testMergeWithVectorizedRe

Re: [PR] Core: Change Delete granularity to file for new tables [iceberg]

2024-11-19 Thread via GitHub
amogh-jahagirdar commented on code in PR #11478: URL: https://github.com/apache/iceberg/pull/11478#discussion_r1848422899 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java: ## @@ -154,7 +155,7 @@ public void testDeleteWithVectorized

Re: [PR] Core: Change Delete granularity to file for new tables [iceberg]

2024-11-19 Thread via GitHub
amogh-jahagirdar commented on code in PR #11478: URL: https://github.com/apache/iceberg/pull/11478#discussion_r1848422899 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java: ## @@ -154,7 +155,7 @@ public void testDeleteWithVectorized

Re: [PR] Core: Change Delete granularity to file for new tables [iceberg]

2024-11-13 Thread via GitHub
nastra commented on PR #11478: URL: https://github.com/apache/iceberg/pull/11478#issuecomment-2474032570 I'm in favor of doing a normal backport so that all Spark versions get the same improvement -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Core: Change Delete granularity to file for new tables [iceberg]

2024-11-13 Thread via GitHub
amogh-jahagirdar commented on PR #11478: URL: https://github.com/apache/iceberg/pull/11478#issuecomment-2474025071 >@amogh-jahagirdar I don't see https://github.com/apache/iceberg/pull/11273 being back-ported to Spark 3.3, 3.4 yet. Shall we skip changes to Spark 3.3, 3.4 until that is done?

Re: [PR] Core: Change Delete granularity to file for new tables [iceberg]

2024-11-13 Thread via GitHub
aokolnychyi commented on code in PR #11478: URL: https://github.com/apache/iceberg/pull/11478#discussion_r1840638062 ## spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestDelete.java: ## @@ -154,7 +155,7 @@ public void testDeleteWithVectorizedReads

Re: [PR] Core: Change Delete granularity to file for new tables [iceberg]

2024-11-13 Thread via GitHub
aokolnychyi commented on code in PR #11478: URL: https://github.com/apache/iceberg/pull/11478#discussion_r1840651564 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,6 +90,8 @@ private static Map persistedProperties(Map rawPr persistedProperties.put(

Re: [PR] Core: Change Delete granularity to file for new tables [iceberg]

2024-11-13 Thread via GitHub
aokolnychyi commented on code in PR #11478: URL: https://github.com/apache/iceberg/pull/11478#discussion_r1840651564 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,6 +90,8 @@ private static Map persistedProperties(Map rawPr persistedProperties.put(

Re: [PR] Core: Change Delete granularity to file for new tables [iceberg]

2024-11-12 Thread via GitHub
manuzhang commented on PR #11478: URL: https://github.com/apache/iceberg/pull/11478#issuecomment-2472286633 I don't see #11273 being back-ported to Spark 3.3, 3.4 yet. Shall we skip changes to Spark 3.3, 3.4 until that is done? -- This is an automated message from the Apache Git Service.

Re: [PR] Core: Change Delete granularity to file for new tables [iceberg]

2024-11-12 Thread via GitHub
nastra commented on code in PR #11478: URL: https://github.com/apache/iceberg/pull/11478#discussion_r1837939172 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,6 +90,8 @@ private static Map persistedProperties(Map rawPr persistedProperties.put(

Re: [PR] Core: Change Delete granularity to file for new tables [iceberg]

2024-11-11 Thread via GitHub
amogh-jahagirdar commented on code in PR #11478: URL: https://github.com/apache/iceberg/pull/11478#discussion_r1837005354 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewritePositionDeleteFilesProcedure.java: ## @@ -49,7 +49,7 @@ private v

Re: [PR] Core: Change Delete granularity to file for new tables [iceberg]

2024-11-08 Thread via GitHub
amogh-jahagirdar commented on code in PR #11478: URL: https://github.com/apache/iceberg/pull/11478#discussion_r1834587711 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,6 +90,8 @@ private static Map persistedProperties(Map rawPr persistedProperties.

Re: [PR] Core: Change Delete granularity to file for new tables [iceberg]

2024-11-05 Thread via GitHub
jbonofre commented on code in PR #11478: URL: https://github.com/apache/iceberg/pull/11478#discussion_r1830477007 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -90,6 +90,8 @@ private static Map persistedProperties(Map rawPr persistedProperties.put(