aokolnychyi commented on code in PR #11478:
URL: https://github.com/apache/iceberg/pull/11478#discussion_r1840651564
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -90,6 +90,8 @@ private static Map<String, String>
persistedProperties(Map<String, String> rawPr
persistedProperties.put(
TableProperties.PARQUET_COMPRESSION,
TableProperties.PARQUET_COMPRESSION_DEFAULT_SINCE_1_4_0);
+ persistedProperties.put(
+ TableProperties.DELETE_GRANULARITY,
TableProperties.DELETE_GRANULARITY_DEFAULT_SINCE_1_8_0);
Review Comment:
This matches what we did for zstd in Parquet. I think it should be fine. An
alternative is to change the default in our Spark conf classes, if we want to
make this specific to Spark. In theory, it would allow us to change this value
only for particular versions of Spark (if we don't want to cherry-pick this to
older Spark versions).
```
public DeleteGranularity deleteGranularity() {
String valueAsString =
confParser
.stringConf()
.option(SparkWriteOptions.DELETE_GRANULARITY)
.tableProperty(TableProperties.DELETE_GRANULARITY)
.defaultValue(TableProperties.DELETE_GRANULARITY_DEFAULT) // this
will have to change
.parse();
return DeleteGranularity.fromString(valueAsString);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
