nastra merged PR #10124:
URL: https://github.com/apache/iceberg/pull/10124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
nastra commented on PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#issuecomment-2058435530
@mrcnc looks like there's a merge conflict. Can you rebase please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
jbonofre commented on code in PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#discussion_r1565319908
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -137,6 +137,10 @@ public void initialize(String name, Map
properties) {
this.connection
nastra commented on code in PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#discussion_r1565243349
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -137,6 +137,10 @@ public void initialize(String name, Map
properties) {
this.connections
nastra commented on code in PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#discussion_r1565243207
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -1020,4 +1062,36 @@ private void initLegacySchema(String jdbcUrl) throws
SQLException {
nastra commented on code in PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#discussion_r1565239656
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -1020,4 +1062,36 @@ private void initLegacySchema(String jdbcUrl) throws
SQLException {
ajantha-bhat commented on code in PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#discussion_r1565210846
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -137,6 +137,10 @@ public void initialize(String name, Map
properties) {
this.connec
jbonofre commented on PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#issuecomment-2053962700
This PR is ok for me. I will prepare another pr to provide create statement
as sql file and document it.
--
This is an automated message from the Apache Git Service.
To respond to t
jbonofre commented on PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#issuecomment-2053563062
We already have a property to determine if we create tables or not. But it's
not directly exposed easily to the users. Let me prepare a PR to improve this.
--
This is an automated m
jbonofre commented on PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#issuecomment-2053562342
Sure thing. I can propose a PR during the weekend. Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
nastra commented on PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#issuecomment-2053550821
thanks @mrcnc, I'll take another look on monday. @jbonofre could you also
take a look please?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
mrcnc commented on PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#issuecomment-2052005953
Thanks for the review and suggestions @nastra! I believe I've addressed all
the feedback in the latest commit
--
This is an automated message from the Apache Git Service.
To respond to
nastra commented on code in PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#discussion_r1562361150
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -161,6 +161,19 @@ public void testInitialize() {
jdbcCatalog.initialize("test_jdbc_catal
nastra commented on code in PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#discussion_r1562359601
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -161,6 +161,19 @@ public void testInitialize() {
jdbcCatalog.initialize("test_jdbc_catal
nastra commented on code in PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#discussion_r1562357647
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -161,6 +161,19 @@ public void testInitialize() {
jdbcCatalog.initialize("test_jdbc_catal
nastra commented on code in PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#discussion_r1562355476
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -843,4 +847,8 @@ public Transaction replaceTransaction() {
return super.replaceTransaction
nastra commented on code in PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#discussion_r1561346286
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -137,6 +137,10 @@ public void initialize(String name, Map
properties) {
this.connections
nastra commented on code in PR #10124:
URL: https://github.com/apache/iceberg/pull/10124#discussion_r1561346286
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -137,6 +137,10 @@ public void initialize(String name, Map
properties) {
this.connections
18 matches
Mail list logo
